Bug 1349695 - Part 3: Convert manual addrefs in txNodeSorter::sortNod…

…eSet. r=peterv Use RefPtr::forget to avoid an AddRef/Release pair when returning.
dothq · Apr 10, 2017 · 3ab41f1 · 3ab41f1
1 parent 7a68f28
commit 3ab41f1
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/dom/xslt/xslt/txNodeSorter.cpp b/dom/xslt/xslt/txNodeSorter.cpp
@@ -127,7 +127,8 @@ txNodeSorter::sortNodeSet(txNodeSet* aNodes, txExecutionState* aEs,
                           txNodeSet** aResult)
 {
     if (mNKeys == 0 || aNodes->isEmpty()) {
-        NS_ADDREF(*aResult = aNodes);
+        RefPtr<txNodeSet> ref(aNodes);
+        ref.forget(aResult);
 
         return NS_OK;
     }
@@ -194,7 +195,7 @@ txNodeSorter::sortNodeSet(txNodeSet* aNodes, txExecutionState* aEs,
 
     delete aEs->popEvalContext();
 
-    NS_ADDREF(*aResult = sortedNodes);
+    sortedNodes.forget(aResult);
 
     return NS_OK;
 }