Skip to content

Commit

Permalink
Bug 1647439 - [remote] Remove 'jobs' argument r=remote-protocol-revie…
Browse files Browse the repository at this point in the history
…wers,jgraham

The environment variable it sets has been removed upstream and in practice we
never run tests in parallel.

Differential Revision: https://phabricator.services.mozilla.com/D82067
  • Loading branch information
mjzffr committed Jul 2, 2020
1 parent 2456548 commit 3cde612
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions remote/mach_commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -336,9 +336,6 @@ def run_test(self, logger, *tests, **params):
`binary`:
Path for the browser binary to use. Defaults to the local
build.
`jobs`:
Number of tests to run in parallel. Defaults to not
parallelise, e.g. `-j1`.
`headless`:
Boolean to indicate whether to activate Firefox' headless mode.
`extra_prefs`:
Expand Down Expand Up @@ -379,8 +376,6 @@ def run_test(self, logger, *tests, **params):
env["PUPPETEER_PRODUCT"] = "firefox"
command = ["run", "unit", "--"] + mocha_options

if params.get("jobs"):
env["PPTR_PARALLEL_TESTS"] = str(params["jobs"])
env["HEADLESS"] = str(params.get("headless", False))

prefs = {}
Expand Down Expand Up @@ -452,11 +447,6 @@ def create_parser_puppeteer():
dest="extra_options",
metavar="<option>=<value>",
help="Defines additional options for `puppeteer.launch`.")
p.add_argument("-j",
dest="jobs",
type=int,
metavar="<N>",
help="Optionally run tests in parallel.")
p.add_argument("-v",
dest="verbosity",
action="count",
Expand Down Expand Up @@ -489,7 +479,7 @@ class PuppeteerTest(MachCommandBase):
description="Run Puppeteer unit tests.",
parser=create_parser_puppeteer)
def puppeteer_test(self, binary=None, enable_fission=False, headless=False,
extra_prefs=None, extra_options=None, jobs=1, verbosity=0,
extra_prefs=None, extra_options=None, verbosity=0,
tests=None, product="firefox", write_results=None,
subset=False, **kwargs):

Expand Down Expand Up @@ -545,7 +535,6 @@ def puppeteer_test(self, binary=None, enable_fission=False, headless=False,
"headless": headless,
"extra_prefs": prefs,
"product": product,
"jobs": jobs,
"extra_launcher_options": options,
"write_results": write_results,
"subset": subset}
Expand Down

0 comments on commit 3cde612

Please sign in to comment.