Bug 1596775: Cleanup shellcheck errors on imported code; r=ahal

Differential Revision: https://phabricator.services.mozilla.com/D55326

--HG--
extra : moz-landing-system : lando

taskcluster/docker/system-symbols-mac/setup.sh

@@ -1,20 +1,20 @@
 #!/bin/sh
 set -v -e -x
 
-ncpu=-j`grep -c ^processor /proc/cpuinfo`
+ncpu=-j$(grep -c ^processor /proc/cpuinfo)
 
 WORK=/setup/
 cd $WORK
 git clone https://github.com/mackyle/xar xar
 cd xar/xar
 ./autogen.sh --prefix=/home/worker
-make $ncpu && make install
+make "$ncpu" && make install
 
 cd $WORK
 git clone -b from_zarvox https://github.com/andreas56/libdmg-hfsplus.git
 cd libdmg-hfsplus
 cmake .
-make $ncpu dmg-bin hfsplus
+make "$ncpu" dmg-bin hfsplus
 # `make install` installs way too much stuff
 cp dmg/dmg hfs/hfsplus /home/worker/bin
 strip /home/worker/bin/dmg /home/worker/bin/hfsplus
@@ -28,7 +28,7 @@ fetch breakpad
 cd src
 touch README
 ./configure
-make $ncpu src/tools/mac/dump_syms/dump_syms_mac
+make "$ncpu" src/tools/mac/dump_syms/dump_syms_mac
 # `make install` is broken because there are two dump_syms binaries.
 cp src/tools/mac/dump_syms/dump_syms_mac /home/worker/bin
 strip /home/worker/bin/dump_syms_mac

tools/crashreporter/system-symbols/mac/run.sh

@@ -2,7 +2,7 @@
 
 set -v -e -x
 
-base="$(realpath $(dirname $0))"
+base="$(realpath "$(dirname "$0")")"
 export PATH="$PATH:/home/worker/bin:$base"
 
 cd /home/worker
@@ -11,9 +11,9 @@ if test "$PROCESSED_PACKAGES"; then
   curl -L "$PROCESSED_PACKAGES" | gzip -dc > processed-packages
   # Prevent reposado from downloading packages that have previously been
   # dumped.
-  for f in `cat processed-packages`; do
-      mkdir -p `dirname $f`
-      touch $f
+  for f in $(cat processed-packages); do
+      mkdir -p "$(dirname "$f")"
+      touch "$f"
   done
 fi
 
@@ -24,6 +24,7 @@ repo_sync --no-download
 
 # Next, fetch just the update packages we're interested in.
 packages=$(python "${base}/list-packages.py")
+# shellcheck disable=SC2086
 repo_sync $packages
 
 du -sh /opt/data-reposado
@@ -36,4 +37,4 @@ python "${base}/PackageSymbolDumper.py" --tracking-file=/home/worker/processed-p
 gzip -c processed-packages > artifacts/processed-packages.gz
 
 cd symbols
-zip -r9 /home/worker/artifacts/target.crashreporter-symbols.zip * || echo "No symbols dumped"
+zip -r9 /home/worker/artifacts/target.crashreporter-symbols.zip ./* || echo "No symbols dumped"

tools/crashreporter/system-symbols/win/run.sh

@@ -2,7 +2,7 @@
 
 set -v -e -x
 
-base="$(realpath $(dirname $0))"
+base="$(realpath "$(dirname "$0")")"
 
 mkdir -p artifacts
 PYTHONPATH=$PWD python "${base}/symsrv-fetch.py" artifacts/target.crashreporter-symbols.zip