Skip to content

Commit

Permalink
Bug 1447879 - Cannot customize about:preferences#home content when sy…
Browse files Browse the repository at this point in the history
…nc or preference searching is disabled. r=k88hudson

Have the home preferences page notify when it loads instead of relying on findInPage to trigger sync pane to init.

MozReview-Commit-ID: EJlJDfYBHFO

--HG--
extra : rebase_source : ae5104ec18aefca9241be1b61072b786fa9e6815
  • Loading branch information
Mardak committed May 31, 2018
1 parent 777a5d8 commit 45c3139
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions browser/components/preferences/in-content/home.js
Original file line number Diff line number Diff line change
Expand Up @@ -372,5 +372,8 @@ let gHomePane = {
makeDisableControllingExtension(PREF_SETTING_TYPE, HOMEPAGE_OVERRIDE_KEY));
document.getElementById("disableNewTabExtension").addEventListener("command",
makeDisableControllingExtension(URL_OVERRIDES_TYPE, NEW_TAB_KEY));

// Notify observers that the UI is now ready
Services.obs.notifyObservers(window, "home-pane-loaded");
}
};
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ ChromeUtils.import("resource://gre/modules/Services.jsm");
ChromeUtils.defineModuleGetter(this, "PluralForm", "resource://gre/modules/PluralForm.jsm");
const {actionTypes: at} = ChromeUtils.import("resource://activity-stream/common/Actions.jsm", {});

const PREFERENCES_LOADED_EVENT = "sync-pane-loaded";
const PREFERENCES_LOADED_EVENT = "home-pane-loaded";
const XUL_NS = "http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul";

// These "section" objects are formatted in a way to be similar to the ones from
Expand Down

0 comments on commit 45c3139

Please sign in to comment.