Bug 1875656: Make CanvasTranslator::AddBuffer diagnostic assert inste…

…ad of release. r=aosmond,gfx-reviewers Differential Revision: https://phabricator.services.mozilla.com/D199222
dothq · Jan 22, 2024 · 45d2b32 · 45d2b32
1 parent 76d38a1
commit 45d2b32
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/gfx/layers/ipc/CanvasTranslator.cpp b/gfx/layers/ipc/CanvasTranslator.cpp
@@ -231,7 +231,14 @@ void CanvasTranslator::AddBuffer(ipc::SharedMemoryBasic::Handle&& aBufferHandle,
     return;
   }
 
-  MOZ_RELEASE_ASSERT(mHeader->readerState == State::Paused);
+  if (mHeader->readerState != State::Paused) {
+    gfxCriticalNote << "CanvasTranslator::AddBuffer bad state "
+                    << uint32_t(State(mHeader->readerState));
+    MOZ_DIAGNOSTIC_ASSERT(false, "mHeader->readerState == State::Paused");
+    Deactivate();
+    return;
+  }
+
   MOZ_ASSERT(mDefaultBufferSize != 0);
 
   // Check and signal the writer when we finish with a buffer, because it