Bug 1831044 - Remove redundant *Throws attributes in URL r=webidl,smaug

D34766 removed the usages by not using URLWorker on those methods. Differential Revision: https://phabricator.services.mozilla.com/D176989
dothq · May 3, 2023 · 4612d82 · 4612d82
1 parent fa6606c
commit 4612d82
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/dom/url/URL.cpp b/dom/url/URL.cpp
@@ -190,7 +190,7 @@ void URL::SetHref(const nsAString& aHref, ErrorResult& aRv) {
   UpdateURLSearchParams();
 }
 
-void URL::GetOrigin(nsAString& aOrigin, ErrorResult& aRv) const {
+void URL::GetOrigin(nsAString& aOrigin) const {
   nsresult rv = nsContentUtils::GetUTFOrigin(URI(), aOrigin);
   if (NS_WARN_IF(NS_FAILED(rv))) {
     aOrigin.Truncate();
@@ -202,7 +202,7 @@ void URL::GetProtocol(nsAString& aProtocol) const {
   aProtocol.Append(char16_t(':'));
 }
 
-void URL::SetProtocol(const nsAString& aProtocol, ErrorResult& aRv) {
+void URL::SetProtocol(const nsAString& aProtocol) {
   nsAString::const_iterator start;
   aProtocol.BeginReading(start);
 

diff --git a/dom/url/URL.h b/dom/url/URL.h
@@ -73,11 +73,11 @@ class URL final : public URLSearchParamsObserver, public nsWrapperCache {
 
   void SetHref(const nsAString& aHref, ErrorResult& aRv);
 
-  void GetOrigin(nsAString& aOrigin, ErrorResult& aRv) const;
+  void GetOrigin(nsAString& aOrigin) const;
 
   void GetProtocol(nsAString& aProtocol) const;
 
-  void SetProtocol(const nsAString& aProtocol, ErrorResult& aRv);
+  void SetProtocol(const nsAString& aProtocol);
 
   void GetUsername(nsAString& aUsername) const;
 

diff --git a/dom/webidl/URL.webidl b/dom/webidl/URL.webidl
@@ -5,7 +5,7 @@
  *
  * The origins of this IDL file are
  * http://url.spec.whatwg.org/#api
- * http://dev.w3.org/2006/webapi/FileAPI/#creating-revoking
+ * https://w3c.github.io/FileAPI/#creating-revoking
  *
  * Copyright © 2012 W3C® (MIT, ERCIM, Keio), All Rights Reserved. W3C
  * liability, trademark and document use rules apply.
@@ -21,9 +21,7 @@ interface URL {
 
   [SetterThrows]
   stringifier attribute USVString href;
-  [GetterThrows]
   readonly attribute USVString origin;
-  [SetterThrows]
            attribute USVString protocol;
            attribute USVString username;
            attribute USVString password;