Bug 725069 - Part 2: Only accept text and element nodes for the edita…

…bility check; r=roc
dothq · Feb 8, 2012 · 4bb54b9 · 4bb54b9
1 parent b560fc0
commit 4bb54b9
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/editor/libeditor/base/nsEditor.cpp b/editor/libeditor/base/nsEditor.cpp
@@ -3636,12 +3636,14 @@ nsEditor::IsEditable(nsIContent *aNode)
     // rely on frameless textnodes being visible.
     return false;
   }
-  if (aNode->NodeType() == nsIDOMNode::COMMENT_NODE)
-    return false;
-  if (aNode->NodeType() != nsIDOMNode::TEXT_NODE)
-    return true;  // not a text node; not invisible
-
-  return IsTextInDirtyFrameVisible(aNode);
+  switch (aNode->NodeType()) {
+    case nsIDOMNode::ELEMENT_NODE:
+      return true; // not a text node; not invisible
+    case nsIDOMNode::TEXT_NODE:
+      return IsTextInDirtyFrameVisible(aNode);
+    default:
+      return false;
+  }
 }
 
 bool