Bug 1843694 Default a11y mochitest to runByManifest and set test_math…

…ml pref in manifest. r=emilio,ahal Enabling the preference in the test file seems to be causing some flakiness, so do it in the manifest instead. Tweak the runner to make that possible for a11y tests. Differential Revision: https://phabricator.services.mozilla.com/D183722
dothq · Jul 19, 2023 · 4cb1405 · 4cb1405
1 parent 3238601
commit 4cb1405
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/accessible/tests/mochitest/textattrs/a11y.ini b/accessible/tests/mochitest/textattrs/a11y.ini
@@ -1,4 +1,6 @@
 [DEFAULT]
+prefs =
+    mathml.legacy_mathvariant_attribute.disabled=true
 support-files =
   !/accessible/tests/mochitest/*.js
   !/accessible/tests/mochitest/moz.png

diff --git a/accessible/tests/mochitest/textattrs/test_mathml.html b/accessible/tests/mochitest/textattrs/test_mathml.html
@@ -30,11 +30,7 @@
     }
 
     SimpleTest.waitForExplicitFinish();
-    SpecialPowers.pushPrefEnv({
-      set: [["mathml.legacy_mathvariant_attribute.disabled", true]],
-    }).then(() => {
-      addA11yLoadEvent(doTest);
-    });
+    addA11yLoadEvent(doTest);
   </script>
 </head>
 <body style="font-size: 12pt">

diff --git a/testing/mochitest/runtests.py b/testing/mochitest/runtests.py
@@ -4104,7 +4104,7 @@ def run_test_harness(parser, options):
     )
 
     options.runByManifest = False
-    if options.flavor in ("plain", "browser", "chrome"):
+    if options.flavor in ("plain", "a11y", "browser", "chrome"):
         options.runByManifest = True
 
     if options.verify or options.verify_fission: