Skip to content

Commit

Permalink
Bug 1814193 - Fix broken macro definition r=sfink
Browse files Browse the repository at this point in the history
The extra trailing backslash resulted in FOR_EACH_GC_PROFILE_TIME not being
expanded at all and the GC profile timing data was never set.

Differential Revision: https://phabricator.services.mozilla.com/D169076
  • Loading branch information
jonco3 committed Feb 7, 2023
1 parent 30468b9 commit 4dfe07e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions js/src/gc/Statistics.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1649,9 +1649,9 @@ Statistics::ProfileDurations Statistics::getProfileTimes(
times[ProfileKey::Background] = SumAllPhaseKinds(slice.totalParallelTimes);

#define GET_PROFILE_TIME(name, text, phase) \
if (phase != PhaseKind::None) { \
if (phase != PhaseKind::NONE) { \
times[ProfileKey::name] = SumPhase(phase, slice.phaseTimes); \
} \
}
FOR_EACH_GC_PROFILE_TIME(GET_PROFILE_TIME)
#undef GET_PROFILE_TIME

Expand Down

0 comments on commit 4dfe07e

Please sign in to comment.