Skip to content

Commit

Permalink
Bug 1584352 - Use sinon matcher instead of exact call list in Normand…
Browse files Browse the repository at this point in the history
…y addon rollout test r=Gijs

This avoids an intermittent test failure when other parts of Firefox set
experiments active while this test is running.

Differential Revision: https://phabricator.services.mozilla.com/D47947

--HG--
extra : moz-landing-system : lando
  • Loading branch information
Michael Cooper committed Oct 2, 2019
1 parent 0e59b1b commit 52e089f
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,10 @@ decorate_task(
sendEventStub.assertEvents([
["enroll", "addon_rollout", recipe.arguments.slug],
]);
Assert.deepEqual(
setExperimentActiveStub.args,
[["test-rollout", "active", { type: "normandy-addonrollout" }]],
ok(
setExperimentActiveStub.calledWithExactly("test-rollout", "active", {
type: "normandy-addonrollout",
}),
"a telemetry experiment should be activated"
);

Expand Down

0 comments on commit 52e089f

Please sign in to comment.