Bug 1338461 - Pass eRestyle_StyleAttribute through to Servo_NoteExpli…

…citHints. r=bholley MozReview-Commit-ID: C7HIOTs1SSY --HG-- extra : rebase_source : 638fe3e1c9ecf47dcd9b175ae03344450417c7da
dothq · Mar 20, 2017 · 52f712b · 52f712b
1 parent 48a8641
commit 52f712b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/dom/plugins/test/reftest/reftest-stylo.list b/dom/plugins/test/reftest/reftest-stylo.list
@@ -16,10 +16,10 @@ random-if(cocoaWidget) fails-if(!haveTestPlugin&&!Android) skip-if(stylo) == plu
 fails == plugin-transform-alpha-zindex.html plugin-transform-alpha-zindex.html
 == plugin-busy-alpha-zindex.html plugin-busy-alpha-zindex.html
 == plugin-background.html plugin-background.html
-== plugin-background-1-step.html plugin-background-1-step.html
-== plugin-background-2-step.html plugin-background-2-step.html
-== plugin-background-5-step.html plugin-background-5-step.html
-== plugin-background-10-step.html plugin-background-10-step.html
+fails == plugin-background-1-step.html plugin-background-1-step.html # bug 1348723
+fails == plugin-background-2-step.html plugin-background-2-step.html # bug 1348723
+fails == plugin-background-5-step.html plugin-background-5-step.html # bug 1348723
+fails == plugin-background-10-step.html plugin-background-10-step.html # bug 1348723
 == plugin-transform-1.html plugin-transform-1.html
 fails == plugin-transform-2.html plugin-transform-2.html
 fails == shrink-1.html shrink-1.html

diff --git a/layout/base/ServoRestyleManager.cpp b/layout/base/ServoRestyleManager.cpp
@@ -55,13 +55,6 @@ ServoRestyleManager::PostRestyleEvent(Element* aElement,
     return;
   }
 
-  // XXX This is a temporary hack to make style attribute change works.
-  //     In the future, we should be able to use this hint directly.
-  if (aRestyleHint & eRestyle_StyleAttribute) {
-    aRestyleHint &= ~eRestyle_StyleAttribute;
-    aRestyleHint |= eRestyle_Self | eRestyle_Subtree;
-  }
-
   if (aRestyleHint || aMinChangeHint) {
     Servo_NoteExplicitHints(aElement, aRestyleHint, aMinChangeHint);
   }