Skip to content

Commit

Permalink
Bug 1620980 - Fix Windows artifact builds after bug 1620165. r=froydnj
Browse files Browse the repository at this point in the history
Both Wine and UPX are necessary when doing artifact builds.

Differential Revision: https://phabricator.services.mozilla.com/D66136

--HG--
extra : moz-landing-system : lando
  • Loading branch information
glandium committed Mar 10, 2020
1 parent 42615ab commit 5573726
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 0 additions & 2 deletions build/moz.configure/windows.configure
Original file line number Diff line number Diff line change
Expand Up @@ -495,5 +495,3 @@ add_old_configure_assignment('LINKER', link)


check_prog('MAKECAB', ('makecab.exe',), allow_missing=True, when=target_is_windows)

check_prog('UPX', ('upx',), allow_missing=True, when=target_is_windows)
5 changes: 3 additions & 2 deletions moz.configure
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,8 @@ set_config('MOZ_PGO', depends('MOZ_PGO')(lambda x: bool(x)))

wine = check_prog(
'WINE', ['wine64', 'wine'], allow_missing=True,
when=depends(target, host, compile_environment)(
lambda t, h, c: c and t.kernel == 'WINNT' and h.kernel == 'Linux'))
when=depends(target, host)(
lambda t, h: t.kernel == 'WINNT' and h.kernel == 'Linux'))


include('build/moz.configure/toolchain.configure',
Expand Down Expand Up @@ -617,6 +617,7 @@ def nsis_flags(host):
set_config('MAKENSISU_FLAGS', nsis_flags)

check_prog('7Z', ('7z', '7za'), allow_missing=True, when=target_is_windows)
check_prog('UPX', ('upx',), allow_missing=True, when=target_is_windows)


@depends(host_c_compiler, c_compiler, bindgen_config_paths)
Expand Down

0 comments on commit 5573726

Please sign in to comment.