Bug 804653 - Make destroying a private docshell update the global cou…

…nt of private docshells instead of waiting an indefinite amount of time for the destructor. r=bz
dothq · Oct 30, 2012 · 5578554 · 5578554
1 parent 42bf588
commit 5578554
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/docshell/base/nsDocShell.cpp b/docshell/base/nsDocShell.cpp
@@ -825,10 +825,6 @@ nsDocShell::~nsDocShell()
                gNumberOfDocShells, mHistoryID);
     }
 #endif
-
-    if (mInPrivateBrowsing) {
-        DecreasePrivateDocShellCount();
-    }
 }
 
 nsresult
@@ -4915,6 +4911,12 @@ nsDocShell::Destroy()
     // Cancel any timers that were set for this docshell; this is needed
     // to break the cycle between us and the timers.
     CancelRefreshURITimers();
+
+    if (mInPrivateBrowsing) {
+        mInPrivateBrowsing = false;
+        DecreasePrivateDocShellCount();
+    }
+
     return NS_OK;
 }