Skip to content

Commit

Permalink
Bug 1840184 - Remove redundant FileSystemWritableFileStreamChild shut…
Browse files Browse the repository at this point in the history
…down check. r=dom-storage-reviewers,janv

Both use cases of the getter of the WritableFileStream pointer are already handling the case where the result is null. In the debug-only check of whether all streams are closed, null result is possible, as evidenced by the bug. When the streams are closed at shutdown, we assume that closing takes place only once and the result is not null but since the second closing can be handled as a no-op, it is not necessary enforce this expectation, following declarative API design.

Differential Revision: https://phabricator.services.mozilla.com/D202589
  • Loading branch information
jjjalkanen committed Feb 28, 2024
1 parent e3d0adf commit 5c00746
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion dom/fs/child/FileSystemWritableFileStreamChild.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ class FileSystemWritableFileStreamChild
NS_INLINE_DECL_REFCOUNTING(FileSystemWritableFileStreamChild, override)

FileSystemWritableFileStream* MutableWritableFileStreamPtr() const {
MOZ_ASSERT(mStream);
return mStream;
}

Expand Down

0 comments on commit 5c00746

Please sign in to comment.