Skip to content

Commit

Permalink
Bug 1680353: Ensure MACOSX_DEPLOYMENT_TARGET is a string r=firefox-bu…
Browse files Browse the repository at this point in the history
…ild-system-reviewers,dmajor

The sysconfig config var of "MACOSX_DEPLOYMENT_TARGET" isn't
consistently a string, so we need to explicitly convert it

Differential Revision: https://phabricator.services.mozilla.com/D98533
  • Loading branch information
Mitchell Hentges committed Dec 3, 2020
1 parent 2c105f0 commit 5ceff3e
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion python/mozbuild/mozbuild/virtualenv.py
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,10 @@ def handle_package(package):
)

if sysconfig_target is not None:
os.environ["MACOSX_DEPLOYMENT_TARGET"] = sysconfig_target
# MACOSX_DEPLOYMENT_TARGET is usually a string (e.g.: "10.14.6"), but
# in some cases it is an int (e.g.: 11). Since environment variables
# must all be str, explicitly convert it.
os.environ["MACOSX_DEPLOYMENT_TARGET"] = str(sysconfig_target)

old_env_variables = {}
for k in IGNORE_ENV_VARIABLES:
Expand Down

0 comments on commit 5ceff3e

Please sign in to comment.