Skip to content

Commit

Permalink
Bug 1477475 - Drop legacy Marionette capabilities duplication. r=whimboo
Browse files Browse the repository at this point in the history
geckodriver currently writes a legacy capabilities structure to the
WebDriver:NewSession command it uses on creating a new WebDriver
session which duplicates the top-level object:

	{capabilities: {<caps>, desiredCapabilities: <caps>}}

Where caps can look something like:

	{acceptInsecureCerts: true, pageLoadStrategy: "normal", ...}

Marionette has picked up the top-level "capabilities" key for a
very long time now, and there is no longer any need to duplicate
the body.
  • Loading branch information
andreastt committed Jul 25, 2018
1 parent 5a1dec7 commit 69211f9
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions testing/geckodriver/src/marionette.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1130,11 +1130,6 @@ impl MarionetteCommand {
data.insert(k.to_string(), v.to_json());
}

// duplicate in capabilities.desiredCapabilities for legacy compat
let mut legacy_caps = BTreeMap::new();
legacy_caps.insert("desiredCapabilities".to_string(), caps.to_json());
data.insert("capabilities".to_string(), legacy_caps.to_json());

(Some("WebDriver:NewSession"), Some(Ok(data)))
}
PerformActions(ref x) => (Some("WebDriver:PerformActions"), Some(x.to_marionette())),
Expand Down

0 comments on commit 69211f9

Please sign in to comment.