Bug 1847469 - Part 19: Remove unused conversion functions. r=iain

Differential Revision: https://phabricator.services.mozilla.com/D185757
dothq · Aug 16, 2023 · 6eeb584 · 6eeb584
1 parent 376421c
commit 6eeb584
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 17 deletions.
diff --git a/js/public/ErrorReport.h b/js/public/ErrorReport.h
@@ -172,13 +172,6 @@ class JSErrorBase {
 
   JSString* newMessageString(JSContext* cx);
 
-  // JSErrorBase uses 1-origin column numbers.
-  // If the caller uses 0-origin column numbers, this method should be used to
-  // convert (bug 1144340).
-  static uint32_t fromZeroOriginToOneOrigin(uint32_t column) {
-    return column + 1;
-  }
-
  private:
   void freeMessage();
 };

diff --git a/js/src/vm/SavedStacks.cpp b/js/src/vm/SavedStacks.cpp
@@ -1988,14 +1988,6 @@ UniqueChars BuildUTF8StackString(JSContext* cx, JSPrincipals* principals,
   return JS_EncodeStringToUTF8(cx, stackStr);
 }
 
-uint32_t FixupMaybeWASMColumnForDisplay(uint32_t column) {
-  if (column & JS::TaggedColumnNumberZeroOrigin::WasmFunctionTag) {
-    return JS::WasmFunctionIndex::DefaultBinarySourceColumnNumberOneOrigin;
-  }
-
-  return JSErrorBase::fromZeroOriginToOneOrigin(column);
-}
-
 } /* namespace js */
 
 namespace JS {

diff --git a/js/src/vm/SavedStacks.h b/js/src/vm/SavedStacks.h
@@ -335,8 +335,6 @@ struct MutableWrappedPtrOperations<SavedStacks::LocationValue, Wrapper>
 JS::UniqueChars BuildUTF8StackString(JSContext* cx, JSPrincipals* principals,
                                      HandleObject stack);
 
-uint32_t FixupMaybeWASMColumnForDisplay(uint32_t column);
-
 js::SavedFrame* UnwrapSavedFrame(JSContext* cx, JSPrincipals* principals,
                                  HandleObject obj,
                                  JS::SavedFrameSelfHosted selfHosted,