Skip to content

Commit

Permalink
Bug 1365802 - In VariantImplementation::moveConstruct, move the aRhs …
Browse files Browse the repository at this point in the history
…rvalue to the next moveConstruct - r=froydnj

Without the Move(), a temporary copy is created and passed as rvalue.

MozReview-Commit-ID: B3MXz6yzO39

--HG--
extra : rebase_source : 897493da0dfac983449da3853fe60bd6ac93117b
  • Loading branch information
squelart committed May 18, 2017
1 parent 9eb6ee9 commit 6f9c60d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mfbt/Variant.h
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ struct VariantImplementation<Tag, N, T, Ts...>
if (aRhs.template is<T>()) {
::new (KnownNotNull, aLhs) T(aRhs.template extract<T>());
} else {
Next::moveConstruct(aLhs, aRhs);
Next::moveConstruct(aLhs, Move(aRhs));
}
}

Expand Down

0 comments on commit 6f9c60d

Please sign in to comment.