forked from mozilla/gecko-dev
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug 1868664 - Make
EditorBase::SetTextDirectionTo use active editin…
…g host if it's an `HTMLEditor` r=m_kato Chrome handles text direction change as a block level format command. I.e., Chrome sets `dir` attributes of enclosing editable blocks of selected leaf nodes. However, aligning to this may require a lot of change and Thunderbird may require the traditional behavior. On the other hand, it's obviously wrong thing that `Ctrl` + `Shift` + `X` in an editable element changes the direction of entire the document since the `<body>` may not be editable. Therefore, this patch just changes the direction change target from `<body>` to active editing host if it's an `HTMLEditor`. Differential Revision: https://phabricator.services.mozilla.com/D195838
- Loading branch information
1 parent
759c68c
commit 78cd50d
Showing
4 changed files
with
96 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
editor/libeditor/tests/test_htmleditor_toggle_text_direction.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| <!doctype html> | ||
| <html> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>Text direction switch target of HTMLEditor</title> | ||
| <script src="/tests/SimpleTest/EventUtils.js"></script> | ||
| <script src="/tests/SimpleTest/SimpleTest.js"></script> | ||
| <link rel="stylesheet" href="/tests/SimpleTest/test.css"> | ||
| <script> | ||
| "use strict"; | ||
|
|
||
| SimpleTest.waitForExplicitFinish(); | ||
| SimpleTest.waitForFocus(async () => { | ||
| await (async function test_in_contenteditable() { | ||
| document.body.innerHTML = "<div><div contenteditable>editable text</div></div>"; | ||
| const editingHost = document.querySelector("div[contenteditable]"); | ||
| editingHost.focus(); | ||
| SpecialPowers.doCommand(window, "cmd_switchTextDirection"); | ||
| is( | ||
| editingHost.getAttribute("dir"), | ||
| "rtl", | ||
| "test_in_contenteditable: dir attr of the editing host should be set" | ||
| ); | ||
| is( | ||
| editingHost.parentElement.getAttribute("dir"), | ||
| null, | ||
| "test_in_contenteditable: dir attr of the parent div of the editing host should not be set" | ||
| ); | ||
| is( | ||
| document.body.getAttribute("dir"), | ||
| null, | ||
| "test_in_contenteditable: dir attr of the <body> should not be set", | ||
| ); | ||
| is( | ||
| document.documentElement.getAttribute("dir"), | ||
| null, | ||
| "test_in_contenteditable: dir attr of the <html> should not be set", | ||
| ); | ||
| })(); | ||
|
|
||
| await (async function test_in_designMode() { | ||
| document.body.innerHTML = "<div>abc</div>"; | ||
| document.designMode = "on"; | ||
| getSelection().collapse(document.querySelector("div").firstChild, 0); | ||
| SpecialPowers.doCommand(window, "cmd_switchTextDirection"); | ||
| is( | ||
| document.querySelector("div").getAttribute("dir"), | ||
| null, | ||
| "test_in_designMode: dir attr of the <div> should not be set", | ||
| ); | ||
| is( | ||
| document.body.getAttribute("dir"), | ||
| "rtl", | ||
| "test_in_designMode: dir attr of the <body> should be set", | ||
| ); | ||
| is( | ||
| document.documentElement.getAttribute("dir"), | ||
| null, | ||
| "test_in_designMode: dir attr of the <html> should not be set", | ||
| ); | ||
| document.designMode = "off"; | ||
| document.body.removeAttribute("dir"); | ||
| document.body.innerHTML = ""; | ||
| document.documentElement.removeAttribute("dir"); | ||
| })(); | ||
|
|
||
| SimpleTest.finish(); | ||
| }); | ||
| </script> | ||
| </head> | ||
| <body> | ||
| </body> | ||
| </html> |