Skip to content

Commit

Permalink
Bug 1712819: Fix VirtualenvManager not being expandable in debugger r…
Browse files Browse the repository at this point in the history
…=ahal

At least in PyCharm, expanding a `VirtualenvManager` instance means
resolving all the properties and fields of the instance.
However, if that property is doing non-trivial work, the debugger
wouldn't run that subprocess while we're stopped at a breakpoint.
So, the instance would sit there with the "Collecting data..." text.

Differential Revision: https://phabricator.services.mozilla.com/D115935
  • Loading branch information
Mitchell Hentges committed May 27, 2021
1 parent bf5ee60 commit 79c5639
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion python/mach_commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ def run_python_tests(
tests = mp.active_tests(
filters=filters,
disabled=False,
python=self.virtualenv_manager.version_info[0],
python=self.virtualenv_manager.version_info()[0],
**mozinfo.info
)

Expand Down
1 change: 0 additions & 1 deletion python/mozbuild/mozbuild/virtualenv.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ def virtualenv_script_path(self):
self.topsrcdir, "third_party", "python", "virtualenv", "virtualenv.py"
)

@property
def version_info(self):
return eval(
subprocess.check_output(
Expand Down

0 comments on commit 79c5639

Please sign in to comment.