Bug 1833687 - Update nimbus-shared to 2.3.0 r=emcminn

Differential Revision: https://phabricator.services.mozilla.com/D178400
dothq · May 24, 2023 · 7b49b2c · 7b49b2c
1 parent 9068b8f
commit 7b49b2c
Show file tree

Hide file tree

Showing 4 changed files with 68 additions and 15 deletions.
diff --git a/.prettierignore b/.prettierignore
@@ -1478,6 +1478,7 @@ security/manager/tools/KnownRootHashes.json
 security/manager/tools/PreloadedHPKPins.json
 services/settings/dumps/
 testing/talos/talos/tests/devtools/addon/content/pages/custom/debugger/static/js/minified.js
+toolkit/components/nimbus/schemas/NimbusExperiment.schema.json
 toolkit/components/pdfjs/content/PdfJsDefaultPreferences.sys.mjs
 toolkit/components/uniffi-js/UniFFIGeneratedScaffolding.cpp
 toolkit/components/uniffi-js/UniFFIFixtureScaffolding.cpp

diff --git a/toolkit/components/nimbus/schemas/NimbusExperiment.schema.json b/toolkit/components/nimbus/schemas/NimbusExperiment.schema.json
@@ -93,7 +93,10 @@
                 "description": "e.g. \"primary\" or \"secondary\""
               }
             },
-            "required": ["slug", "priority"]
+            "required": [
+              "slug",
+              "priority"
+            ]
           },
           "description": "A list of outcomes relevant to the experiment analysis."
         },
@@ -133,11 +136,18 @@
                         "description": "Optional extra params for the feature (this should be validated against a schema)"
                       }
                     },
-                    "required": ["featureId", "value"],
+                    "required": [
+                      "featureId",
+                      "value"
+                    ],
                     "description": "A single feature configuration"
                   }
                 },
-                "required": ["slug", "ratio", "feature"]
+                "required": [
+                  "slug",
+                  "ratio",
+                  "feature"
+                ]
               }
             },
             {
@@ -170,7 +180,11 @@
                         "additionalProperties": {}
                       }
                     },
-                    "required": ["featureId", "enabled", "value"],
+                    "required": [
+                      "featureId",
+                      "enabled",
+                      "value"
+                    ],
                     "description": "The feature key must be provided with valid values to prevent crashes if the DTO is encountered by Desktop clients earlier than version 95."
                   },
                   "features": {
@@ -188,12 +202,20 @@
                           "description": "Optional extra params for the feature (this should be validated against a schema)"
                         }
                       },
-                      "required": ["featureId", "value"]
+                      "required": [
+                        "featureId",
+                        "value"
+                      ]
                     },
                     "description": "An array of feature configurations"
                   }
                 },
-                "required": ["slug", "ratio", "feature", "features"]
+                "required": [
+                  "slug",
+                  "ratio",
+                  "feature",
+                  "features"
+                ]
               }
             },
             {
@@ -225,33 +247,52 @@
                           "description": "Optional extra params for the feature (this should be validated against a schema)"
                         }
                       },
-                      "required": ["featureId", "value"]
+                      "required": [
+                        "featureId",
+                        "value"
+                      ]
                     },
                     "description": "An array of feature configurations"
                   }
                 },
-                "required": ["slug", "ratio", "features"]
+                "required": [
+                  "slug",
+                  "ratio",
+                  "features"
+                ]
               }
             }
           ],
           "description": "Branch configuration for the experiment"
         },
         "targeting": {
-          "type": ["string", "null"],
+          "type": [
+            "string",
+            "null"
+          ],
           "description": "JEXL expression used to filter experiments based on locale, geo, etc."
         },
         "startDate": {
-          "type": ["string", "null"],
+          "type": [
+            "string",
+            "null"
+          ],
           "description": "Actual publish date of the experiment Note that this value is expected to be null in Remote Settings.",
           "format": "date"
         },
         "enrollmentEndDate": {
-          "type": ["string", "null"],
+          "type": [
+            "string",
+            "null"
+          ],
           "description": "Actual enrollment end date of the experiment. Note that this value is expected to be null in Remote Settings.",
           "format": "date"
         },
         "endDate": {
-          "type": ["string", "null"],
+          "type": [
+            "string",
+            "null"
+          ],
           "description": "Actual end date of the experiment. Note that this value is expected to be null in Remote Settings.",
           "format": "date"
         },
@@ -264,7 +305,10 @@
           "description": "This represents the number of days that we expect to enroll new users. Note that this property is only used during the analysis phase (not by the SDK)"
         },
         "referenceBranch": {
-          "type": ["string", "null"],
+          "type": [
+            "string",
+            "null"
+          ],
           "description": "The slug of the reference branch (that is, which branch we consider \"control\")"
         },
         "featureValidationOptOut": {
@@ -287,6 +331,13 @@
             }
           ],
           "description": "Per-locale localization substitutions.\n\nThe top level key is the locale (e.g., \"en-US\" or \"fr\"). Each entry is a mapping of string IDs to their localized equivalents.\n\nOnly supported on desktop."
+        },
+        "locales": {
+          "type": "array",
+          "items": {
+            "type": "string"
+          },
+          "description": "The list of locale codes (e.g., \"en-US\" or \"fr\") that this experiment is targeting.\n\nIf null, all locales are targeted."
         }
       },
       "required": [

diff --git a/toolkit/components/nimbus/schemas/moz.yaml b/toolkit/components/nimbus/schemas/moz.yaml
@@ -9,8 +9,8 @@ origin:
   description: "Shared data and schemas for Project Nimbus"
   url: "https://github.com/mozilla/nimbus-shared"
   license: "MPL-2.0"
-  release: "version 2.1.0"
-  revision: "v2.1.0"
+  release: "version 2.3.0"
+  revision: "v2.3.0"
 
 vendoring:
   url: "https://github.com/mozilla/nimbus-shared"

diff --git a/tools/rewriting/Generated.txt b/tools/rewriting/Generated.txt
@@ -21,6 +21,7 @@ security/manager/tools/KnownRootHashes.json
 security/manager/tools/PreloadedHPKPins.json
 services/settings/dumps/
 testing/talos/talos/tests/devtools/addon/content/pages/custom/debugger/static/js/minified.js
+toolkit/components/nimbus/schemas/NimbusExperiment.schema.json
 toolkit/components/pdfjs/content/PdfJsDefaultPreferences.sys.mjs
 toolkit/components/uniffi-js/UniFFIGeneratedScaffolding.cpp
 toolkit/components/uniffi-js/UniFFIFixtureScaffolding.cpp