Bug 1414121. P1 - let mozDumpDebugInfo() return a promise. r=bz

MozReview-Commit-ID: Klfr3AYdSCG --HG-- extra : rebase_source : 9f2c89306a274b1d563f53413df668d9b11c7b90 extra : source : 93969bf54c26fd097807f1280db5b6deb20c01db
dothq · Nov 3, 2017 · 7fd4aab · 7fd4aab
1 parent 60c5093
commit 7fd4aab
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/dom/html/HTMLMediaElement.cpp b/dom/html/HTMLMediaElement.cpp
@@ -1605,12 +1605,19 @@ HTMLMediaElement::MozRequestDebugInfo(ErrorResult& aRv)
   return promise.forget();
 }
 
-void
+already_AddRefed<Promise>
 HTMLMediaElement::MozDumpDebugInfo()
 {
+  ErrorResult rv;
+  RefPtr<Promise> promise = CreateDOMPromise(rv);
+  if (NS_WARN_IF(rv.Failed())) {
+    return nullptr;
+  }
   if (mDecoder) {
     mDecoder->DumpDebugInfo();
   }
+  promise->MaybeResolveWithUndefined();
+  return promise.forget();
 }
 
 void

diff --git a/dom/html/HTMLMediaElement.h b/dom/html/HTMLMediaElement.h
@@ -625,7 +625,7 @@ class HTMLMediaElement : public nsGenericHTMLElement,
   // data from decoder/reader/MDSM. Used for debugging purposes.
   already_AddRefed<Promise> MozRequestDebugInfo(ErrorResult& aRv);
 
-  void MozDumpDebugInfo();
+  already_AddRefed<Promise> MozDumpDebugInfo();
 
   // For use by mochitests. Enabling pref "media.test.video-suspend"
   void SetVisible(bool aVisible);

diff --git a/dom/webidl/HTMLMediaElement.webidl b/dom/webidl/HTMLMediaElement.webidl
@@ -108,7 +108,7 @@ partial interface HTMLMediaElement {
   Promise<DOMString> mozRequestDebugInfo();
 
   [Pref="media.test.dumpDebugInfo"]
-  void mozDumpDebugInfo();
+  Promise<void> mozDumpDebugInfo();
 
   attribute MediaStream? srcObject;