Skip to content

Commit

Permalink
Bug 1720614 - Remove HTTPS_RR_WAITING_TIME, r=necko-reviewers,valentin
Browse files Browse the repository at this point in the history
  • Loading branch information
KershawChang committed Aug 9, 2021
1 parent 7afe5a7 commit 8422e6d
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 22 deletions.
9 changes: 0 additions & 9 deletions netwerk/protocol/http/nsHttpTransaction.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,6 @@ nsresult nsHttpTransaction::Init(
if (target) {
if (StaticPrefs::network_dns_force_waiting_https_rr()) {
mCaps |= NS_HTTP_FORCE_WAIT_HTTP_RR;
mHTTPSRRQueryStart = TimeStamp::Now();
}

mResolver = new HTTPSRecordResolver(this);
Expand Down Expand Up @@ -3034,14 +3033,6 @@ nsresult nsHttpTransaction::OnHTTPSRRAvailable(
auto updateHTTPSSVCReceivedStage = MakeScopeExit([&] {
mHTTPSSVCReceivedStage = receivedStage;

if (!mHTTPSRRQueryStart.IsNull()) {
AccumulateTimeDelta(Telemetry::HTTPS_RR_WAITING_TIME,
HTTPS_RR_IS_USED(mHTTPSSVCReceivedStage)
? "with_https_rr"_ns
: "no_https_rr"_ns,
mHTTPSRRQueryStart, TimeStamp::Now());
}

// In the case that an HTTPS RR is unavailable, we should call
// ProcessPendingQ to make sure this transition to be processed soon.
if (!mHTTPSSVCRecord) {
Expand Down
1 change: 0 additions & 1 deletion netwerk/protocol/http/nsHttpTransaction.h
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,6 @@ class nsHttpTransaction final : public nsAHttpTransaction,

// The time when the transaction was submitted to the Connection Manager
TimeStamp mPendingTime;
TimeStamp mHTTPSRRQueryStart;
TimeDuration mPendingDurationTime;

uint64_t mTopBrowsingContextId{0};
Expand Down
12 changes: 0 additions & 12 deletions toolkit/components/telemetry/Histograms.json
Original file line number Diff line number Diff line change
Expand Up @@ -16645,17 +16645,5 @@
"Fetch",
"Unexpected"
]
},
"HTTPS_RR_WAITING_TIME": {
"record_in_processes": ["main", "socket"],
"products": ["firefox"],
"alert_emails": ["[email protected]", "[email protected]"],
"bug_numbers": [1714506],
"expires_in_version": "93",
"kind": "exponential",
"high": 5000,
"n_buckets": 100,
"keyed": true,
"description": "The time that a transaction is waiting for HTTPS RR"
}
}

0 comments on commit 8422e6d

Please sign in to comment.