Bug 1861201: Support ariaBrailleLabel and ariaBrailleRoleDescription …

…IDL attributes. r=webidl,smaug Differential Revision: https://phabricator.services.mozilla.com/D202195
dothq · Feb 20, 2024 · 85ddb41 · 85ddb41
1 parent 1fbd02c
commit 85ddb41
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 18 deletions.
diff --git a/dom/base/Element.h b/dom/base/Element.h
@@ -661,6 +661,9 @@ class Element : public FragmentOrElement {
   // AriaAttributes
   REFLECT_NULLABLE_DOMSTRING_ATTR(AriaAtomic, aria_atomic)
   REFLECT_NULLABLE_DOMSTRING_ATTR(AriaAutoComplete, aria_autocomplete)
+  REFLECT_NULLABLE_DOMSTRING_ATTR(AriaBrailleLabel, aria_braillelabel)
+  REFLECT_NULLABLE_DOMSTRING_ATTR(AriaBrailleRoleDescription,
+                                  aria_brailleroledescription)
   REFLECT_NULLABLE_DOMSTRING_ATTR(AriaBusy, aria_busy)
   REFLECT_NULLABLE_DOMSTRING_ATTR(AriaChecked, aria_checked)
   REFLECT_NULLABLE_DOMSTRING_ATTR(AriaColCount, aria_colcount)

diff --git a/dom/html/ElementInternals.h b/dom/html/ElementInternals.h
@@ -122,6 +122,8 @@ class ElementInternals final : public nsIFormControl,
   ARIA_REFLECT_ATTR(AriaAtomic, aria_atomic)
   ARIA_REFLECT_ATTR(AriaAutoComplete, aria_autocomplete)
   ARIA_REFLECT_ATTR(AriaBusy, aria_busy)
+  ARIA_REFLECT_ATTR(AriaBrailleLabel, aria_braillelabel)
+  ARIA_REFLECT_ATTR(AriaBrailleRoleDescription, aria_brailleroledescription)
   ARIA_REFLECT_ATTR(AriaChecked, aria_checked)
   ARIA_REFLECT_ATTR(AriaColCount, aria_colcount)
   ARIA_REFLECT_ATTR(AriaColIndex, aria_colindex)

diff --git a/dom/webidl/ARIAMixin.webidl b/dom/webidl/ARIAMixin.webidl
@@ -20,6 +20,12 @@ interface mixin ARIAMixin {
   [Pref="accessibility.ARIAReflection.enabled", CEReactions, SetterThrows]
   attribute DOMString? ariaAutoComplete;
 
+  [Pref="accessibility.ARIAReflection.enabled", CEReactions, SetterThrows]
+  attribute DOMString? ariaBrailleLabel;
+
+  [Pref="accessibility.ARIAReflection.enabled", CEReactions, SetterThrows]
+  attribute DOMString? ariaBrailleRoleDescription;
+
   [Pref="accessibility.ARIAReflection.enabled", CEReactions, SetterThrows]
   attribute DOMString? ariaBusy;
 

diff --git a/testing/web-platform/meta/html/dom/aria-attribute-reflection.html.ini b/testing/web-platform/meta/html/dom/aria-attribute-reflection.html.ini
diff --git a/testing/web-platform/meta/wai-aria/idlharness.window.js.ini b/testing/web-platform/meta/wai-aria/idlharness.window.js.ini
@@ -46,15 +46,3 @@
 
   [Element interface: element must inherit property "ariaErrorMessageElements" with the proper type]
     expected: FAIL
-
-  [Element interface: attribute ariaBrailleLabel]
-    expected: FAIL
-
-  [Element interface: attribute ariaBrailleRoleDescription]
-    expected: FAIL
-
-  [Element interface: element must inherit property "ariaBrailleLabel" with the proper type]
-    expected: FAIL
-
-  [Element interface: element must inherit property "ariaBrailleRoleDescription" with the proper type]
-    expected: FAIL
diff --git a/xpcom/ds/StaticAtoms.py b/xpcom/ds/StaticAtoms.py
@@ -121,6 +121,8 @@
     Atom("aria_activedescendant", "aria-activedescendant"),
     Atom("aria_atomic", "aria-atomic"),
     Atom("aria_autocomplete", "aria-autocomplete"),
+    Atom("aria_braillelabel", "aria-braillelabel"),
+    Atom("aria_brailleroledescription", "aria-brailleroledescription"),
     Atom("aria_busy", "aria-busy"),
     Atom("aria_checked", "aria-checked"),
     Atom("aria_controls", "aria-controls"),