Bug 1782527 - [devtools] Change devtools.chrome-debug-mode default va…

…lue to parent-process. r=jdescottes.

Differential Revision: https://phabricator.services.mozilla.com/D153432

browser/app/profile/firefox.js

@@ -2296,7 +2296,7 @@ pref("devtools.browsertoolbox.fission", true);
 //   All processes, all documents, all workers, all add-ons.
 // - "parent-process" will restrict debugging to the parent process
 //   All privileged javascript, documents and workers running in the parent process.
-pref("devtools.browsertoolbox.scope", "everything");
+pref("devtools.browsertoolbox.scope", "parent-process");
 
 // This preference will enable watching top-level targets from the server side.
 pref("devtools.target-switching.server.enabled", true);

devtools/client/debugger/test/mochitest/browser_dbg-browser-toolbox-unselected-pause.js

@@ -17,6 +17,7 @@ Services.scriptloader.loadSubScript(
 
 add_task(async function() {
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
 
   // Make sure the toolbox opens with the webconsole initially selected.
   await pushPref("devtools.browsertoolbox.panel", "webconsole");

devtools/client/debugger/test/mochitest/browser_dbg-browser-toolbox-workers.js

@@ -17,6 +17,7 @@ Services.scriptloader.loadSubScript(
 
 add_task(async function() {
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
   await pushPref("dom.serviceWorkers.enabled", true);
   await pushPref("dom.serviceWorkers.testing.enabled", true);
 

devtools/client/debugger/test/mochitest/browser_dbg-features-browser-toolbox-source-tree.js

@@ -22,6 +22,7 @@ Services.scriptloader.loadSubScript(
 add_task(async function testSourceTreeNamesForWebExtensions() {
   await pushPref("devtools.chrome.enabled", true);
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
   const extension = await installAndStartContentScriptExtension();
 
   const dbg = await initDebugger("doc-content-script-sources.html");

devtools/client/framework/browser-toolbox/test/browser_browser_toolbox_debugger.js

@@ -30,6 +30,8 @@ add_task(async function runTest() {
     ""
   );
 
+  await pushPref("devtools.browsertoolbox.scope", "everything");
+
   const ToolboxTask = await initBrowserToolboxTask({
     enableBrowserToolboxFission: true,
   });

devtools/client/framework/browser-toolbox/test/browser_browser_toolbox_evaluation_context.js

@@ -22,6 +22,8 @@ add_task(async function() {
   await pushPref("devtools.webconsole.input.context", true);
   // Force EFT to have targets for all WindowGlobals
   await pushPref("devtools.every-frame-target.enabled", true);
+  // Enable Multiprocess Browser Toolbox
+  await pushPref("devtools.browsertoolbox.scope", "everything");
 
   // Open the test *before* opening the Browser toolbox in order to have the right target title.
   // Once created, the target won't update its title, and so would be "New Tab", instead of "Test tab"

devtools/client/framework/browser-toolbox/test/browser_browser_toolbox_fission_contentframe_inspector.js

@@ -24,6 +24,7 @@ requestLongerTimeout(4);
  * test locally.
  */
 add_task(async function() {
+  await pushPref("devtools.browsertoolbox.scope", "everything");
   const ToolboxTask = await initBrowserToolboxTask({
     enableBrowserToolboxFission: true,
   });

devtools/client/framework/browser-toolbox/test/browser_browser_toolbox_fission_inspector.js

@@ -23,6 +23,8 @@ requestLongerTimeout(4);
 add_task(async function() {
   // Forces the Browser Toolbox to open on the inspector by default
   await pushPref("devtools.browsertoolbox.panel", "inspector");
+  // Enable Multiprocess Browser Toolbox
+  await pushPref("devtools.browsertoolbox.scope", "everything");
 
   const ToolboxTask = await initBrowserToolboxTask({
     enableBrowserToolboxFission: true,

devtools/client/framework/browser-toolbox/test/browser_browser_toolbox_fission_inspector_webextension.js

@@ -58,6 +58,8 @@ add_task(async function() {
 
   // Forces the Browser Toolbox to open on the inspector by default
   await pushPref("devtools.browsertoolbox.panel", "inspector");
+  // Enable Multiprocess Browser Toolbox
+  await pushPref("devtools.browsertoolbox.scope", "everything");
   const ToolboxTask = await initBrowserToolboxTask({
     enableBrowserToolboxFission: true,
   });

devtools/client/framework/browser-toolbox/test/browser_browser_toolbox_print_preview.js

@@ -23,6 +23,9 @@ add_task(async function() {
   // Forces the Browser Toolbox to open on the inspector by default
   await pushPref("devtools.browsertoolbox.panel", "inspector");
 
+  // Enable Multiprocess Browser Toolbox
+  await pushPref("devtools.browsertoolbox.scope", "everything");
+
   // Open the tab *after* opening the Browser Toolbox in order to force creating the remote frames
   // late and exercise frame target watching code.
   await addTab(`data:text/html,<div id="test-div">PRINT PREVIEW TEST</div>`);

devtools/client/framework/browser-toolbox/test/browser_browser_toolbox_ruleview_stylesheet.js

@@ -22,6 +22,8 @@ requestLongerTimeout(4);
 add_task(async function() {
   // Forces the Browser Toolbox to open on the inspector by default
   await pushPref("devtools.browsertoolbox.panel", "inspector");
+  // Enable Multiprocess Browser Toolbox
+  await pushPref("devtools.browsertoolbox.scope", "everything");
 
   const ToolboxTask = await initBrowserToolboxTask({
     enableBrowserToolboxFission: true,

devtools/client/framework/browser-toolbox/test/browser_browser_toolbox_unavailable_children.js

@@ -24,6 +24,7 @@ requestLongerTimeout(4);
 add_task(async function() {
   // Forces the Browser Toolbox to open on the inspector by default
   await pushPref("devtools.browsertoolbox.panel", "inspector");
+  await pushPref("devtools.browsertoolbox.scope", "everything");
 
   const tab = await addTab(
     "https://example.com/document-builder.sjs?html=<div id=pick-me>Pickme"

devtools/client/framework/browser-toolbox/test/browser_browser_toolbox_watchedByDevTools.js

@@ -19,6 +19,7 @@ add_task(async function() {
     "devtools.browsertoolbox.fission",
     false
   );
+  await pushPref("devtools.browsertoolbox.scope", "everything");
 
   const topWindow = Services.wm.getMostRecentWindow("navigator:browser");
   is(

devtools/client/framework/test/allocations/browser_allocations_browser_console.js

@@ -48,6 +48,9 @@ add_task(async function() {
   await SpecialPowers.pushPrefEnv({
     set: [["devtools.browsertoolbox.fission", true]],
   });
+  await SpecialPowers.pushPrefEnv({
+    set: [["devtools.browsertoolbox.scope", "everything"]],
+  });
 
   const tab = await addTab(TEST_URL);
 

devtools/client/styleeditor/test/browser_toolbox_styleeditor.js

@@ -24,6 +24,7 @@ Services.scriptloader.loadSubScript(
 
 add_task(async function() {
   await addTab(TEST_URI);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
   const ToolboxTask = await initBrowserToolboxTask({
     enableBrowserToolboxFission: true,
   });

devtools/client/webconsole/test/browser/browser_console.js

@@ -38,6 +38,7 @@ add_task(async function() {
   info(
     "Check browser console messages with devtools.browsertoolbox.fission set to true"
   );
+  await pushPref("devtools.browsertoolbox.scope", "everything");
   await pushPref("devtools.browsertoolbox.fission", true);
   await testMessages();
 

devtools/client/webconsole/test/browser/browser_console_clear_cache.js

@@ -12,6 +12,7 @@ const TEST_URI =
 add_task(async function() {
   await pushPref("devtools.browserconsole.contentMessages", true);
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
 
   await addTab(TEST_URI);
   let hud = await BrowserConsoleManager.toggleBrowserConsole();

devtools/client/webconsole/test/browser/browser_console_clear_closed_tab.js

@@ -14,6 +14,7 @@ add_task(async function() {
   await pushPref("devtools.browserconsole.contentMessages", true);
   // Enable Fission browser console to see the logged content object
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
 
   // Disable the preloaded process as it creates processes intermittently
   // which forces the emission of RDP requests we aren't correctly waiting for.

devtools/client/webconsole/test/browser/browser_console_content_getters.js

@@ -13,6 +13,7 @@ add_task(async function() {
   await pushPref("devtools.browserconsole.contentMessages", true);
   // Enable Fission browser console to see the logged content object
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
 
   await addTab(TEST_URI);
 

devtools/client/webconsole/test/browser/browser_console_content_longstring.js

@@ -18,6 +18,7 @@ add_task(async function() {
   await pushPref("devtools.browserconsole.contentMessages", true);
   // Enable Fission browser console to see the logged content object
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
 
   await addTab(TEST_URI);
 

devtools/client/webconsole/test/browser/browser_console_content_object.js

@@ -15,6 +15,7 @@ add_task(async function() {
   await pushPref("devtools.browserconsole.contentMessages", true);
   // Enable Fission browser console to see the logged content object
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
 
   await addTab(TEST_URI);
 

devtools/client/webconsole/test/browser/browser_console_content_object_context_menu.js

@@ -18,6 +18,7 @@ add_task(async function() {
   await pushPref("devtools.browserconsole.contentMessages", true);
   // Enable Fission browser console to see the logged content object
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
 
   await addTab(TEST_URI);
 

devtools/client/webconsole/test/browser/browser_console_content_object_in_sidebar.js

@@ -25,6 +25,7 @@ add_task(async function() {
   await pushPref("devtools.browserconsole.contentMessages", true);
   // Enable Fission browser console to see the logged content object
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
 
   await addTab(TEST_URI);
 

devtools/client/webconsole/test/browser/browser_console_context_menu_entries.js

@@ -11,6 +11,7 @@ const TEST_URI =
 
 add_task(async function() {
   await pushPref("devtools.browserconsole.contentMessages", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
   // Enable net messages in the console for this test.
   await pushPref("devtools.browserconsole.filter.net", true);
   // This is required for testing the text input in the browser console:

devtools/client/webconsole/test/browser/browser_console_context_menu_export_console_output.js

@@ -15,6 +15,7 @@ add_task(async function() {
   await pushPref("devtools.browserconsole.contentMessages", true);
   // Enable Fission browser console to see the logged content object
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
 
   await addTab(TEST_URI);
 

devtools/client/webconsole/test/browser/browser_console_devtools_loader_exception.js

@@ -14,6 +14,14 @@ add_task(async function() {
   // which forces the emission of RDP requests we aren't correctly waiting for.
   await pushPref("dom.ipc.processPrelaunch.enabled", false);
 
+  const isFissionEnabledForBrowserConsole = Services.prefs.getBoolPref(
+    "devtools.browsertoolbox.fission",
+    false
+  );
+  if (isFissionEnabledForBrowserConsole) {
+    await pushPref("devtools.browsertoolbox.scope", "everything");
+  }
+
   const wcHud = await openNewTabAndConsole(TEST_URI);
   ok(wcHud, "web console opened");
 
@@ -57,11 +65,6 @@ add_task(async function() {
   ok(url.includes("toolbox.js"), "we have the expected view source URL");
   ok(!url.includes("->"), "no -> in the URL given to view-source");
 
-  const isFissionEnabledForBrowserConsole = Services.prefs.getBoolPref(
-    "devtools.browsertoolbox.fission",
-    false
-  );
-
   const { targetCommand } = bcHud.commands;
   // If Fission is not enabled for the Browser Console (e.g. in Beta at this moment),
   // the target list won't watch for Frame targets, and as a result we won't have issues

devtools/client/webconsole/test/browser/browser_console_error_source_click.js

@@ -16,6 +16,7 @@ add_task(async function() {
   await pushPref("dom.ipc.processPrelaunch.enabled", false);
 
   await pushPref("devtools.browserconsole.contentMessages", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
   await addTab(TEST_URI);
 
   const hud = await BrowserConsoleManager.toggleBrowserConsole();

devtools/client/webconsole/test/browser/browser_console_evaluation_context_selector.js

@@ -9,6 +9,7 @@ add_task(async function() {
   await pushPref("devtools.chrome.enabled", true);
   await pushPref("devtools.every-frame-target.enabled", true);
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
 
   const hud = await BrowserConsoleManager.toggleBrowserConsole();
 

devtools/client/webconsole/test/browser/browser_console_ignore_debugger_statement.js

@@ -18,6 +18,7 @@ add_task(async function() {
   // Show the content messages
   await pushPref("devtools.browserconsole.contentMessages", true);
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
 
   info("Open the Browser Console");
   const hud = await BrowserConsoleManager.toggleBrowserConsole();

devtools/client/webconsole/test/browser/browser_console_webconsole_iframe_messages.js

@@ -38,6 +38,7 @@ add_task(async function() {
   await pushPref("devtools.browserconsole.contentMessages", true);
   // Enable Fission browser console to see the logged content object
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
   hud = await BrowserConsoleManager.toggleBrowserConsole();
   ok(hud, "browser console opened");
   await testMessages(hud);

devtools/client/webconsole/test/browser/browser_console_webconsole_private_browsing.js

@@ -32,6 +32,7 @@ add_task(async function() {
   await testBrowserConsole(publicTab);
 
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
   await testBrowserConsole(publicTab);
 });
 

devtools/client/webconsole/test/browser/browser_console_webextension.js

@@ -12,6 +12,7 @@ const TEST_URI =
 
 add_task(async function() {
   await pushPref("devtools.browserconsole.contentMessages", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
   await addTab(TEST_URI);
 
   info("Check with devtools.browsertoolbox.fission set to false");

devtools/client/webconsole/test/browser/browser_jsterm_hide_when_devtools_chrome_enabled_false.js

@@ -31,6 +31,9 @@ add_task(async function() {
   await pushPref("devtools.webconsole.input.editor", true);
   await pushPref("devtools.browserconsole.input.editor", true);
 
+  // Enable Multiprocess Browser Console
+  await pushPref("devtools.browsertoolbox.scope", "everything");
+
   // Needed for the execute() function below
   await pushPref("security.allow_parent_unrestricted_js_loads", true);
 

devtools/shared/commands/resource/tests/browser_browser_resources_console_messages.js

@@ -10,6 +10,7 @@ const TEST_URL = URL_ROOT_SSL + "early_console_document.html";
 add_task(async function() {
   // Enable Multiprocess Browser Toolbox (it's still disabled for non-Nightly builds).
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
 
   const {
     client,

devtools/shared/commands/resource/tests/browser_resources_several_resources.js

@@ -13,6 +13,7 @@ add_task(async function() {
   // devtools.browsertoolbox.fission should be true to monitor resources from
   // remote browsers & frames.
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
 
   // Open a test tab
   const tab = await addTab("data:text/html,Root Node tests");

devtools/shared/commands/target/tests/browser_target_command_bfcache.js

@@ -499,6 +499,7 @@ async function testIframeNavigations() {
       1,
       "Without fission/EFT, there is only the top level target"
     );
+    await commands.destroy();
     return;
   }
   is(targets.length, 2, "retrieved the top level and the iframe targets");

devtools/shared/commands/target/tests/browser_target_command_browser_workers.js

@@ -13,6 +13,7 @@ const SERVICE_WORKER_URL = URL_ROOT_SSL + "test_service_worker.js";
 add_task(async function() {
   // Enabled fission's pref as the TargetCommand is almost disabled without it
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
 
   // Disable the preloaded process as it creates processes intermittently
   // which forces the emission of RDP requests we aren't correctly waiting for.

devtools/shared/commands/target/tests/browser_target_command_frames.js

@@ -20,6 +20,7 @@ add_task(async function() {
 
   // Enabled fission prefs
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
   // Disable the preloaded process as it gets created lazily and may interfere
   // with process count assertions
   await pushPref("dom.ipc.processPrelaunch.enabled", false);

devtools/shared/commands/target/tests/browser_target_command_processes.js

@@ -11,6 +11,7 @@ const TEST_URL =
 add_task(async function() {
   // Enabled fission's pref as the TargetCommand is almost disabled without it
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
   // Disable the preloaded process as it gets created lazily and may interfere
   // with process count assertions
   await pushPref("dom.ipc.processPrelaunch.enabled", false);

devtools/shared/commands/target/tests/browser_target_command_tab_workers_bfcache_navigation.js

@@ -128,4 +128,7 @@ add_task(async function() {
     iframeWorkerTargetAfterGoingBack,
     "The target list handled the worker created in the iframe from the BF Cache"
   );
+
+  targetCommand.destroy();
+  await commands.destroy();
 });

devtools/shared/commands/target/tests/browser_target_command_various_descriptors.js

@@ -12,6 +12,7 @@ const CHROME_WORKER_URL = CHROME_URL_ROOT + "test_worker.js";
 add_task(async function() {
   // Enabled fission prefs
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
   // Disable the preloaded process as it gets created lazily and may interfere
   // with process count assertions
   await pushPref("dom.ipc.processPrelaunch.enabled", false);

devtools/shared/commands/target/tests/browser_target_command_watchTargets.js

@@ -11,6 +11,7 @@ const TEST_URL =
 add_task(async function() {
   // Enabled fission's pref as the TargetCommand is almost disabled without it
   await pushPref("devtools.browsertoolbox.fission", true);
+  await pushPref("devtools.browsertoolbox.scope", "everything");
   // Disable the preloaded process as it gets created lazily and may interfere
   // with process count assertions
   await pushPref("dom.ipc.processPrelaunch.enabled", false);