Bug 1628715 - Part 3: Make fallible nsTArray::Assign nodiscard. r=xpc…

…om-reviewers,erahm Differential Revision: https://phabricator.services.mozilla.com/D70384
dothq · Apr 24, 2020 · 93004ea · 93004ea
1 parent 3ff0c69
commit 93004ea
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/dom/prio/test/gtest/TestPrioEncoder.cpp b/dom/prio/test/gtest/TestPrioEncoder.cpp
@@ -44,7 +44,7 @@ TEST(PrioEncoder, BooleanLimitExceeded)
     *(sequence.AppendElement(mozilla::fallible)) = rand() % 2;
   }
 
-  prioParams.mBooleans.Assign(sequence);
+  ASSERT_TRUE(prioParams.mBooleans.Assign(sequence));
 
   mozilla::dom::RootedDictionary<mozilla::dom::PrioEncodedData> prioEncodedData(
       cx);
@@ -183,7 +183,7 @@ TEST(PrioEncoder, VerifyFull)
   *(sequence.AppendElement(mozilla::fallible)) = dataItems[0];
   *(sequence.AppendElement(mozilla::fallible)) = dataItems[1];
   *(sequence.AppendElement(mozilla::fallible)) = dataItems[2];
-  prioParams.mBooleans.Assign(sequence);
+  ASSERT_TRUE(prioParams.mBooleans.Assign(sequence));
 
   mozilla::dom::RootedDictionary<mozilla::dom::PrioEncodedData> prioEncodedData(
       cx);

diff --git a/xpcom/ds/nsTArray.h b/xpcom/ds/nsTArray.h
@@ -1467,7 +1467,7 @@ class nsTArray_Impl
   //
 
   template <class Allocator, typename ActualAlloc = Alloc>
-  typename ActualAlloc::ResultType Assign(
+  [[nodiscard]] typename ActualAlloc::ResultType Assign(
       const nsTArray_Impl<E, Allocator>& aOther) {
     return ActualAlloc::ConvertBoolToResultType(
         !!ReplaceElementsAt<E, ActualAlloc>(0, Length(), aOther.Elements(),