bug 1392603 - Remove toolkit/crashreporter/tools/win32. r=gsvelto

We have prebuilt dump_syms binaries in toolkit/crashreporter/tools/win32 from the days when we didn't build it as part of the build. There's one per MSVC version, since the APIs it uses are version-specific, but we don't actually support building with the MSVC versions corresponding to the binaries in that directory anymore, so we should just remove them. The only code change necessary here is changing the functional test to skip running the test if a dump_syms binary isn't available. MozReview-Commit-ID: IBuJZMVfv7C Differential Revision: https://phabricator.services.mozilla.com/D15717 --HG-- extra : moz-landing-system : lando
dothq · Jan 4, 2019 · 96349b5 · 96349b5
1 parent 12c357c
commit 96349b5
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 6 deletions.
diff --git a/toolkit/crashreporter/tools/unit-symbolstore.py b/toolkit/crashreporter/tools/unit-symbolstore.py
@@ -479,12 +479,7 @@ def setUp(self):
                                               'dist', 'host', 'bin',
                                               'dump_syms.exe')
             else:
-                self.dump_syms = os.path.join(self.topsrcdir,
-                                              'toolkit',
-                                              'crashreporter',
-                                              'tools',
-                                              'win32',
-                                              'dump_syms_vc{_MSC_VER}.exe'.format(**buildconfig.substs))
+                self.skip_test = True
             self.target_bin = os.path.join(buildconfig.topobjdir,
                                            'dist', 'bin',
                                            'firefox.exe')

diff --git a/toolkit/crashreporter/tools/win32/dump_syms_vc1600.exe b/toolkit/crashreporter/tools/win32/dump_syms_vc1600.exe
diff --git a/toolkit/crashreporter/tools/win32/dump_syms_vc1700.exe b/toolkit/crashreporter/tools/win32/dump_syms_vc1700.exe
diff --git a/toolkit/crashreporter/tools/win32/dump_syms_vc1800.exe b/toolkit/crashreporter/tools/win32/dump_syms_vc1800.exe