Bug 1607172 - Update ESLint to the latest version and use ignorePatte…

…rns to ignore paths listed in ThirdPartyPaths.txt. r=mossop

Differential Revision: https://phabricator.services.mozilla.com/D59691

--HG--
extra : moz-landing-system : lando

.eslintignore

@@ -1,3 +1,13 @@
+# Please DO NOT add more third party files to this file.
+# They should be added to tools/rewriting/ThirdPartyPaths.txt instead.
+# The remaining third-party paths will be removed in bug 1608799.
+
+# This file should only be used for exclusions where we have:
+# - preprocessed files
+# - generated files that are for some reason checked into source
+# - intentionally invalid files
+# - build directories and other items that we need to ignore
+
 # Always ignore node_modules.
 **/node_modules/
 

.eslintrc.js

@@ -4,6 +4,7 @@ const xpcshellTestConfig = require("eslint-plugin-mozilla/lib/configs/xpcshell-t
 const browserTestConfig = require("eslint-plugin-mozilla/lib/configs/browser-test.js");
 const mochitestTestConfig = require("eslint-plugin-mozilla/lib/configs/mochitest-test.js");
 const chromeTestConfig = require("eslint-plugin-mozilla/lib/configs/chrome-test.js");
+const fs = require("fs");
 
 /**
  * Some configurations have overrides, which can't be specified within overrides,
@@ -32,7 +33,12 @@ const chromeTestPaths = [
   "**/test*/chrome/",
 ];
 
+const ignorePatterns =
+  fs.readFileSync("tools/rewriting/ThirdPartyPaths.txt")
+    .toString("utf-8").split("\n");
+
 module.exports = {
+  ignorePatterns,
   // New rules and configurations should generally be added in
   // tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js to
   // allow external repositories that use the plugin to pick them up as well.

browser/components/places/content/places-tree.js

@@ -135,6 +135,7 @@
 
       // Force an initial build.
       if (this.place) {
+        // eslint-disable-next-line no-self-assign
         this.place = this.place;
       }
     }
@@ -183,6 +184,7 @@
         this.setAttribute("flatList", val);
         // reload with the last place set
         if (this.place) {
+          // eslint-disable-next-line no-self-assign
           this.place = this.place;
         }
       }