Bug 1816664 Rename addSessionData/removeSessionData methods of RootMe…

…ssageHandler to addSessionDataItem/removeSessionDataItem r=webdriver-reviewers,Sasha Differential Revision: https://phabricator.services.mozilla.com/D172513
dothq · Mar 21, 2023 · 9ac5475 · 9ac5475
1 parent c385272
commit 9ac5475
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/remote/shared/messagehandler/RootMessageHandler.sys.mjs b/remote/shared/messagehandler/RootMessageHandler.sys.mjs
@@ -82,7 +82,7 @@ export class RootMessageHandler extends MessageHandler {
    * RootMessageHandler and propagates the information via a command to existing
    * MessageHandlers.
    */
-  addSessionData(sessionData = {}) {
+  addSessionDataItem(sessionData = {}) {
     sessionData.method = lazy.SessionDataMethod.Add;
     return this.updateSessionData([sessionData]);
   }
@@ -136,7 +136,7 @@ export class RootMessageHandler extends MessageHandler {
    * RootMessageHandler and propagates the information via a command to existing
    * MessageHandlers.
    */
-  removeSessionData(sessionData = {}) {
+  removeSessionDataItem(sessionData = {}) {
     sessionData.method = lazy.SessionDataMethod.Remove;
     return this.updateSessionData([sessionData]);
   }

diff --git a/remote/shared/messagehandler/test/browser/browser_events_handler.js b/remote/shared/messagehandler/test/browser/browser_events_handler.js
@@ -15,7 +15,7 @@ add_task(async function test_windowGlobalHandlerCreated() {
   );
 
   info("Add a new session data item to get window global handlers created");
-  await rootMessageHandler.addSessionData({
+  await rootMessageHandler.addSessionDataItem({
     moduleName: "command",
     category: "browser_session_data_browser_element",
     contextDescriptor: {

diff --git a/remote/shared/messagehandler/test/browser/browser_session_data.js b/remote/shared/messagehandler/test/browser/browser_session_data.js
@@ -192,7 +192,7 @@ add_task(async function test_sessionDataRootOnlyModule() {
   info("Test that adding SessionData items works the root module");
   // Updating the session data on the root message handler should not cause
   // failures for other message handlers if the module only exists for root.
-  await rootMessageHandler.addSessionData({
+  await rootMessageHandler.addSessionDataItem({
     moduleName: "rootOnly",
     category: "session_data_root_only",
     contextDescriptor: {
@@ -222,7 +222,7 @@ add_task(async function test_sessionDataRootOnlyModule() {
   );
 
   info("Now test that removing items also works on the root module");
-  await rootMessageHandler.removeSessionData({
+  await rootMessageHandler.removeSessionDataItem({
     moduleName: "rootOnly",
     category: "session_data_root_only",
     contextDescriptor: {

diff --git a/remote/shared/messagehandler/test/browser/browser_session_data_browser_element.js b/remote/shared/messagehandler/test/browser/browser_session_data_browser_element.js
@@ -42,7 +42,7 @@ add_task(async function test_session_data_broadcast() {
   root.on("message-handler-event", onRootEvent);
 
   info("Add a new session data item, expect one return value");
-  await root.addSessionData({
+  await root.addSessionDataItem({
     moduleName: "command",
     category: "browser_session_data_browser_element",
     contextDescriptor: {

diff --git a/remote/shared/messagehandler/test/browser/browser_session_data_constructor_race.js b/remote/shared/messagehandler/test/browser/browser_session_data_constructor_race.js
@@ -17,7 +17,7 @@ add_task(async function() {
   const root = createRootMessageHandler("session-id-event");
 
   info("Add some session data for the command module");
-  await root.addSessionData({
+  await root.addSessionDataItem({
     moduleName: "command",
     category: "testCategory",
     contextDescriptor: contextDescriptorAll,

diff --git a/remote/webdriver-bidi/modules/root/script.sys.mjs b/remote/webdriver-bidi/modules/root/script.sys.mjs
@@ -132,7 +132,7 @@ class ScriptModule extends Module {
 
     this.#preloadScriptMap.set(script, preloadScript);
 
-    await this.messageHandler.addSessionData({
+    await this.messageHandler.addSessionDataItem({
       category: "preload-script",
       moduleName: "script",
       values: [
@@ -526,7 +526,7 @@ class ScriptModule extends Module {
 
     const preloadScript = this.#preloadScriptMap.get(script);
 
-    await this.messageHandler.removeSessionData({
+    await this.messageHandler.removeSessionDataItem({
       category: "preload-script",
       moduleName: "script",
       values: [