Bug 1517682 - Drop layout.css.image-orientation.enabled pref. r=heycam

It was enabled by default in bug 825771. Depends on D15703 Differential Revision: https://phabricator.services.mozilla.com/D15704 --HG-- extra : moz-landing-system : lando
dothq · Jan 4, 2019 · 9bdfa0c · 9bdfa0c
1 parent 6aaa816
commit 9bdfa0c
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 19 deletions.
diff --git a/devtools/shared/css/generated/properties-db.js b/devtools/shared/css/generated/properties-db.js
@@ -9368,10 +9368,6 @@ exports.PREFERENCES = [
     "font-optical-sizing",
     "layout.css.font-variations.enabled"
   ],
-  [
-    "image-orientation",
-    "layout.css.image-orientation.enabled"
-  ],
   [
     "initial-letter",
     "layout.css.initial-letter.enabled"

diff --git a/layout/style/test/property_database.js b/layout/style/test/property_database.js
@@ -5206,6 +5206,14 @@ var gCSSProperties = {
     other_values: [ "0", "0.3", "-7.3" ],
     invalid_values: []
   },
+  "image-orientation": {
+    domProp: "imageOrientation",
+    inherited: true,
+    type: CSS_TYPE_LONGHAND,
+    initial_values: [ "none" ],
+    other_values: [ "from-image" ],
+    invalid_values: [ "0", "0deg" ],
+  },
   "image-rendering": {
     domProp: "imageRendering",
     inherited: true,
@@ -7196,16 +7204,6 @@ if (IsCSSPropertyPrefEnabled("layout.css.contain.enabled")) {
   };
 }
 
-if (IsCSSPropertyPrefEnabled("layout.css.image-orientation.enabled")) {
-  gCSSProperties["image-orientation"] = {
-    domProp: "imageOrientation",
-    inherited: true,
-    type: CSS_TYPE_LONGHAND,
-    initial_values: [ "none" ],
-    other_values: [ "from-image" ],
-    invalid_values: [ "0", "0deg" ]
-  };
-}
 
 if (IsCSSPropertyPrefEnabled("layout.css.initial-letter.enabled")) {
   gCSSProperties["initial-letter"] = {

diff --git a/layout/style/test/test_computed_style_prefs.html b/layout/style/test/test_computed_style_prefs.html
@@ -68,7 +68,6 @@
 // ----
 
 var gProps = {
-  "layout.css.image-orientation.enabled": ["image-orientation"],
   "layout.css.mix-blend-mode.enabled": ["mix-blend-mode"],
   "layout.css.isolation.enabled": [ "isolation"],
   "layout.css.touch_action.enabled": ["touch-action"],

diff --git a/modules/libpref/init/all.js b/modules/libpref/init/all.js
@@ -3075,9 +3075,6 @@ pref("layout.css.convertFromNode.enabled", true);
 // Is support for CSS text-justify property enabled?
 pref("layout.css.text-justify.enabled", true);
 
-// Is support for the CSS image-orientation property enabled?
-pref("layout.css.image-orientation.enabled", true);
-
 // Is the paint-order property supported for HTML text?
 // (It is always supported for SVG.)
 pref("layout.css.paint-order.enabled", true);

diff --git a/servo/components/style/properties/longhands/inherited_box.mako.rs b/servo/components/style/properties/longhands/inherited_box.mako.rs
@@ -77,6 +77,5 @@ ${helpers.single_keyword(
     products="gecko",
     gecko_enum_prefix="StyleImageOrientation",
     animation_value_type="discrete",
-    gecko_pref="layout.css.image-orientation.enabled",
     spec="https://drafts.csswg.org/css-images/#propdef-image-orientation",
 )}