Skip to content

Commit

Permalink
Bug 1347796 - Bump stack size 3x larger than default for win64 ASan. …
Browse files Browse the repository at this point in the history
…r=dbaron,gps

This is a similar issue to bug 582910 which the stack isn't big enough
to run the tests that recurse deeply. Set it 3x larger because the
offical site states they've seen up to 3x stack memory increase for
ASan, also the number was confirmed by the measurements in bug
1259796.


MozReview-Commit-ID: FLASlkVrEUM

--HG--
extra : rebase_source : 3e82439e3df7b1e2fa1759c9693bd197431c9f71
  • Loading branch information
janus926 committed Mar 20, 2017
1 parent 24fdfb8 commit 9df0768
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions config/config.mk
Original file line number Diff line number Diff line change
Expand Up @@ -413,10 +413,15 @@ endif # WINNT

ifdef _MSC_VER
ifeq ($(CPU_ARCH),x86_64)
ifdef MOZ_ASAN
# ASan could have 3x stack memory usage of normal builds.
WIN32_EXE_LDFLAGS += -STACK:6291456
else
# set stack to 2MB on x64 build. See bug 582910
WIN32_EXE_LDFLAGS += -STACK:2097152
endif
endif
endif

#
# Include any personal overrides the user might think are needed.
Expand Down

0 comments on commit 9df0768

Please sign in to comment.