Skip to content

Commit

Permalink
Bug 1601076 - Fix some broken BUG_COMPONENTS in moz.build files; r=jm…
Browse files Browse the repository at this point in the history
…aher

Some of these were obvious typos. Others probably reflect once-correct components
that have been combined, split, or otherwise obsoleted; for these I've tried to
use the component associated with the bugs for recent changes to the affected files.

Differential Revision: https://phabricator.services.mozilla.com/D55756

--HG--
extra : moz-landing-system : lando
  • Loading branch information
gbrownmozilla committed Dec 4, 2019
1 parent 47bb8fc commit 9e59579
Show file tree
Hide file tree
Showing 26 changed files with 45 additions and 48 deletions.
2 changes: 1 addition & 1 deletion browser/components/library/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ JAR_MANIFESTS += ['jar.mn']
FINAL_LIBRARY = 'browsercomps'

with Files('**'):
BUG_COMPONENT = ('Firefox', 'Library')
BUG_COMPONENT = ('Firefox', 'New Tab Page')
2 changes: 1 addition & 1 deletion browser/components/syncedtabs/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ EXTRA_JS_MODULES.syncedtabs += [
]

with Files('**'):
BUG_COMPONENT = ('Firefox', 'Synced tabs')
BUG_COMPONENT = ('Firefox', 'Sync')

2 changes: 1 addition & 1 deletion browser/extensions/report-site-issue/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ FINAL_TARGET_FILES.features['[email protected]'].icons += [
BROWSER_CHROME_MANIFESTS += ['test/browser/browser.ini']

with Files('**'):
BUG_COMPONENT = ('Web Compatibility Tools', 'General')
BUG_COMPONENT = ('Web Compatibility', 'Tooling & Investigations')
2 changes: 1 addition & 1 deletion browser/extensions/webcompat/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,4 @@ FINAL_TARGET_FILES.features['[email protected]']['lib'] += [
]

with Files('**'):
BUG_COMPONENT = ('Web Compatibility Tools', 'Go Faster')
BUG_COMPONENT = ('Web Compatibility', 'Tooling & Investigations')
2 changes: 1 addition & 1 deletion docshell/test/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ with Files('mochitest/*402210*'):
BUG_COMPONENT = ('Core', 'DOM: Security')

with Files('mochitest/*509055*'):
BUG_COMPONENT = ('Core', 'History: Global')
BUG_COMPONENT = ('Firefox', 'Bookmarks & History')

with Files('mochitest/*511449*'):
BUG_COMPONENT = ('Core', 'Widget: Cocoa')
Expand Down
2 changes: 1 addition & 1 deletion dom/reporting/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ IPDL_SOURCES += [
include('/ipc/chromium/chromium-config.mozbuild')

with Files('**'):
BUG_COMPONENT = ('DOM', 'Security')
BUG_COMPONENT = ('Core', 'DOM: Security')

FINAL_LIBRARY = 'xul'

Expand Down
10 changes: 5 additions & 5 deletions dom/tests/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ with Files("browser/*unload*"):
BUG_COMPONENT = ("Core", "DOM: Events")

with Files("browser/*1238427*"):
BUG_COMPONENT = ("Core", "Geolocation")
BUG_COMPONENT = ("Core", "DOM: Geolocation")

with Files("browser/*Geolocation*"):
BUG_COMPONENT = ("Core", "Geolocation")
BUG_COMPONENT = ("Core", "DOM: Geolocation")

with Files("browser/*geo_*"):
BUG_COMPONENT = ("Core", "Geolocation")
BUG_COMPONENT = ("Core", "DOM: Geolocation")

with Files("browser/browser_cancel_keydown_keypress_event.js"):
BUG_COMPONENT = ("Core", "DOM: UI Events & Focus Handling")
Expand Down Expand Up @@ -80,7 +80,7 @@ with Files("mochitest/general/**"):
BUG_COMPONENT = ("Core", "DOM: Core & HTML")

with Files("mochitest/geolocation/**"):
BUG_COMPONENT = ("Core", "Geolocation")
BUG_COMPONENT = ("Core", "DOM: Geolocation")

with Files("mochitest/localstorage/**"):
BUG_COMPONENT = ("Core", "Storage: localStorage & sessionStorage")
Expand Down Expand Up @@ -140,7 +140,7 @@ with Files("unit/**"):
BUG_COMPONENT = ("Core", "DOM: Core & HTML")

with Files("unit/*geolocation*"):
BUG_COMPONENT = ("Core", "Geolocation")
BUG_COMPONENT = ("Core", "DOM: Geolocation")

with Files("unit/test_bug465752.js"):
BUG_COMPONENT = ("Core", "CSS Parsing and Computation")
Expand Down
2 changes: 1 addition & 1 deletion layout/xul/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ with Files('**'):
BUG_COMPONENT = ('Core', 'XUL')

with Files('*Menu*'):
BUG_COMPONENT = ('Core', 'XP Toolkit/Widgets: Menus')
BUG_COMPONENT = ('Firefox', 'Menus')

if CONFIG['ENABLE_TESTS']:
MOCHITEST_MANIFESTS += ['test/mochitest.ini']
Expand Down
5 changes: 1 addition & 4 deletions mobile/android/app/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,10 @@
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

with Files('**'):
BUG_COMPONENT = ('Firefox for Android', 'Build Config & IDE Support')

with Files('mobile*'):
BUG_COMPONENT = ('Firefox for Android', 'General')

with Files('omnijar/**'):
BUG_COMPONENT = ('Firefox for Android', 'Build Config & IDE Support')
BUG_COMPONENT = ('Firefox for Android', 'General')

for var in ('APP_NAME', 'APP_VERSION'):
DEFINES[var] = CONFIG['MOZ_%s' % var]
Expand Down
2 changes: 1 addition & 1 deletion mobile/android/base/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

with Files('**'):
BUG_COMPONENT = ('Firefox for Android', 'Build Config & IDE Support')
BUG_COMPONENT = ('Firefox for Android', 'General')

with Files('locales/**'):
BUG_COMPONENT = ('Firefox for Android', 'General')
Expand Down
2 changes: 1 addition & 1 deletion mobile/android/installer/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

with Files('**'):
BUG_COMPONENT = ('Firefox for Android', 'Build Config & IDE Support')
BUG_COMPONENT = ('Firefox for Android', 'General')
6 changes: 3 additions & 3 deletions mobile/android/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

with Files('**'):
BUG_COMPONENT = ('Firefox for Android', 'Build Config & IDE Support')
BUG_COMPONENT = ('Firefox for Android', 'General')
SCHEDULES.exclusive = ['android']

with Files('branding/**'):
BUG_COMPONENT = ('Firefox for Android', 'General')

with Files('config/**'):
BUG_COMPONENT = ('Firefox for Android', 'Build Config & IDE Support')
BUG_COMPONENT = ('Firefox for Android', 'General')

with Files('docs/**'):
BUG_COMPONENT = ('Firefox for Android', 'General')
Expand All @@ -30,7 +30,7 @@ with Files('geckoview_example/**'):
BUG_COMPONENT = ('GeckoView', 'General')

with Files('gradle/**'):
BUG_COMPONENT = ('Firefox for Android', 'Build Config & IDE Support')
BUG_COMPONENT = ('Firefox for Android', 'General')

with Files('themes/**'):
BUG_COMPONENT = ('Firefox for Android', 'Theme and Visual Design')
Expand Down
4 changes: 2 additions & 2 deletions mobile/locales/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

with Files('**'):
BUG_COMPONENT = ('Firefox for Android', 'Locale Switching')
BUG_COMPONENT = ('Firefox for Android', 'Locale switching and selection')

JAR_MANIFESTS += ['jar.mn']
JAR_MANIFESTS += ['jar.mn']
2 changes: 1 addition & 1 deletion moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ with Files('GNUmakefile'):
BUG_COMPONENT = ('Firefox Build System', 'General')

with Files('*gradle*'):
BUG_COMPONENT = ('Firefox for Android', 'Build Config & IDE Support')
BUG_COMPONENT = ('Firefox for Android', 'General')
SCHEDULES.exclusive = ['android']

with Files('*.json'):
Expand Down
4 changes: 2 additions & 2 deletions python/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ with Files('mozbuild/**'):
BUG_COMPONENT = ('Firefox Build System', 'General')

with Files('mozlint/**'):
BUG_COMPONENT = ('Testing', 'Lint')
BUG_COMPONENT = ('Firefox Build System', 'Linting and Formatting')

with Files('mozversioncontrol/**'):
BUG_COMPONENT = ('Firefox Build System', 'General')
Expand All @@ -33,7 +33,7 @@ with Files('l10n/**'):
BUG_COMPONENT = ('Firefox Build System', 'General')

with Files('mozrelease/**'):
BUG_COMPONENT = ('Release Engineering', 'Release Automation')
BUG_COMPONENT = ('Release Engineering', 'General')

with Files('mach_commands.py'):
BUG_COMPONENT = ('Testing', 'Python Test')
Expand Down
2 changes: 1 addition & 1 deletion services/fxaccounts/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

with Files('**'):
BUG_COMPONENT = ('Core', 'fxAccounts')
BUG_COMPONENT = ('Firefox', 'Firefox Accounts')

DIRS += ['interfaces']

Expand Down
2 changes: 1 addition & 1 deletion testing/config/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ with Files("telemetry*"):
BUG_COMPONENT = ("Toolkit", "Telemetry")

with Files("tooltool-manifests/**"):
BUG_COMPONENT = ("Release Engineering", "Mozharness")
BUG_COMPONENT = ("Release Engineering", "Applications: MozharnessCore")
2 changes: 1 addition & 1 deletion testing/modules/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ with Files("tests/xpcshell/**"):
BUG_COMPONENT = ("Testing", "XPCShell Harness")

with Files("tests/browser/**"):
BUG_COMPONENT = ("Testing", "BrowserTest")
BUG_COMPONENT = ("Testing", "General")
2 changes: 1 addition & 1 deletion testing/tps/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

with Files("**"):
BUG_COMPONENT = ("Testing", "TPS")
BUG_COMPONENT = ("Testing", "General")
14 changes: 7 additions & 7 deletions testing/web-platform/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ with Files("mozilla/tests/placeholder"):
BUG_COMPONENT = ("Testing", "web-platform-tests")

with Files("mozilla/tests/wasm/**"):
BUG_COMPONENT = ("Core", "Javascript: Web Assembly")
BUG_COMPONENT = ("Core", "Javascript: WebAssembly")

with Files("update/**"):
BUG_COMPONENT = ("Testing", "web-platform-tests")
Expand Down Expand Up @@ -481,7 +481,7 @@ with Files("tests/gamepad/**"):
BUG_COMPONENT = ("Core", "DOM: Device Interfaces")

with Files("tests/geolocation-API/**"):
BUG_COMPONENT = ("Core", "Geolocation")
BUG_COMPONENT = ("Core", "DOM: Geolocation")

with Files("tests/gyroscope/**"):
BUG_COMPONENT = ("Core", "DOM: Device Interfaces")
Expand Down Expand Up @@ -624,7 +624,7 @@ with Files("tests/pointerlock/**"):
BUG_COMPONENT = ("Core", "DOM: Events")

with Files("tests/preload/**"):
BUG_COMPONENT = ("Core", "DOM: Core & Html")
BUG_COMPONENT = ("Core", "DOM: Core & HTML")

with Files("tests/presentation-api/**"):
BUG_COMPONENT = ("Core", "DOM: Core & HTML")
Expand Down Expand Up @@ -682,7 +682,7 @@ with Files("tests/storage/**"):
BUG_COMPONENT = ("Core", "Storage: Quota Manager")

with Files("tests/streams/**"):
BUG_COMPONENT = ("Core", "Javascript Engine")
BUG_COMPONENT = ("Core", "JavaScript Engine")

with Files("tests/subresource-integrity/**"):
BUG_COMPONENT = ("Core", "DOM: Security")
Expand Down Expand Up @@ -724,7 +724,7 @@ with Files("tests/wai-aria/**"):
BUG_COMPONENT = ("Core", "Disability Access APIs")

with Files("tests/wasm/**"):
BUG_COMPONENT = ("Core", "Javascript: Web Assembly")
BUG_COMPONENT = ("Core", "Javascript: WebAssembly")

with Files("tests/web-animations/**"):
BUG_COMPONENT = ("Core", "DOM: Animation")
Expand Down Expand Up @@ -763,10 +763,10 @@ with Files("tests/webusb/**"):
BUG_COMPONENT = ("Core", "DOM: Device Interfaces")

with Files("tests/webvr/**"):
BUG_COMPONENT = ("Core", "DOM: WebVR")
BUG_COMPONENT = ("Core", "WebVR")

with Files("tests/webxr/**"):
BUG_COMPONENT = ("Core", "DOM: WebVR")
BUG_COMPONENT = ("Core", "WebVR")

with Files("tests/webvtt/**"):
BUG_COMPONENT = ("Core", "Audio/Video: Playback")
Expand Down
8 changes: 4 additions & 4 deletions third_party/python/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ with Files('dlmanager/**'):
BUG_COMPONENT = ('Firefox Build System', 'General')

with Files('enum34/**'):
BUG_COMPONENT = ('Release Engineering', 'General Automation')
BUG_COMPONENT = ('Release Engineering', 'General')

with Files('futures/**'):
BUG_COMPONENT = ('Firefox Build System', 'General')

with Files('jsmin/**'):
BUG_COMPONENT = ('Firefox for Android', 'Build Config & IDE Support')
BUG_COMPONENT = ('Firefox for Android', 'General')

with Files('lldbutils/**'):
BUG_COMPONENT = ('Core', 'General')
Expand All @@ -45,7 +45,7 @@ with Files('mohawk/**'):
BUG_COMPONENT = ('Taskcluster', 'Platform Libraries')

with Files('mozilla-version/**'):
BUG_COMPONENT = ('Release Engineering', 'General Automation')
BUG_COMPONENT = ('Release Engineering', 'General')

with Files('psutil/**'):
BUG_COMPONENT = ('Firefox Build System', 'General')
Expand All @@ -54,7 +54,7 @@ with Files('py/**'):
BUG_COMPONENT = ('Firefox Build System', 'General')

with Files('pyasn1/**'):
BUG_COMPONENT = ('Release Engineering', 'General Automation')
BUG_COMPONENT = ('Release Engineering', 'General')

with Files('pyasn1-modules/**'):
BUG_COMPONENT = ('Core', 'Security: PSM')
Expand Down
4 changes: 2 additions & 2 deletions toolkit/content/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,9 @@ with Files('tests/chrome/*451540*'):
BUG_COMPONENT = ('Toolkit', 'Find Toolbar')

with Files('tests/chrome/*557987*'):
BUG_COMPONENT = ('Core', 'XP Toolkit/Widgets: Menus')
BUG_COMPONENT = ('Firefox', 'Menus')
with Files('tests/chrome/*562554*'):
BUG_COMPONENT = ('Core', 'XP Toolkit/Widgets: Menus')
BUG_COMPONENT = ('Firefox', 'Menus')

with Files('tests/chrome/*570192*'):
BUG_COMPONENT = ('Firefox', 'Session Restore')
Expand Down
2 changes: 1 addition & 1 deletion toolkit/modules/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ with Files('IndexedDB.jsm'):
BUG_COMPONENT = ('Toolkit', 'Async Tooling')

with Files('InlineSpellChecker*.jsm'):
BUG_COMPONENT = ('Core', 'Spell Checker')
BUG_COMPONENT = ('Core', 'Spelling checker')

with Files('Integration.jsm'):
BUG_COMPONENT = ('Toolkit', 'Async Tooling')
Expand Down
4 changes: 2 additions & 2 deletions toolkit/mozapps/extensions/test/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ XPCSHELL_TESTS_MANIFESTS += [
]

with Files('xpcshell/rs-blocklist/**'):
BUG_COMPONENT = ('Toolkit', 'Blockist Implementation')
BUG_COMPONENT = ('Toolkit', 'Blocklist Implementation')

with Files('xpcshell/xml-blocklist/**'):
BUG_COMPONENT = ('Toolkit', 'Blockist Implementation')
BUG_COMPONENT = ('Toolkit', 'Blocklist Implementation')
2 changes: 1 addition & 1 deletion tools/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ with Files("tryselect/selectors/release.py"):
BUG_COMPONENT = ("Release Engineering", "General")

with Files("update-packaging/**"):
BUG_COMPONENT = ("Release Engineering", "Other")
BUG_COMPONENT = ("Release Engineering", "General")

with Files("update-verify/**"):
BUG_COMPONENT = ("Release Engineering", "Release Automation: Updates")
Expand Down
2 changes: 1 addition & 1 deletion widget/android/bindings/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

with Files("**"):
BUG_COMPONENT = ("Firefox for Android", "Graphics, Panning and Zooming")
BUG_COMPONENT = ("Firefox for Android", "General")

# List of stems to generate .cpp and .h files for. To add a stem, add it to
# this list and ensure that $(stem)-classes.txt exists in this directory.
Expand Down

0 comments on commit 9e59579

Please sign in to comment.