Skip to content

Commit

Permalink
Bug 1882122 - Add remaining space design tokens r=desktop-theme-revie…
Browse files Browse the repository at this point in the history
…wers,reusable-components-reviewers,settings-reviewers,mstriemer,emilio

Added
- `--space-medium`
- `--space-large`

Changed
- `--space-xlarge` has a new value and the old one is now `--space-xxlarge`

Differential Revision: https://phabricator.services.mozilla.com/D202739
  • Loading branch information
Jules Simplicio committed Feb 29, 2024
1 parent bd034cf commit a10c268
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 15 deletions.
28 changes: 14 additions & 14 deletions browser/themes/shared/preferences/preferences.css
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ radio {
*/

.subcategory:not([hidden]) ~ .subcategory {
padding-top: var(--space-xlarge);
padding-top: var(--space-xxlarge);
border-top: 1px solid var(--in-content-border-color);
}

Expand Down Expand Up @@ -596,7 +596,7 @@ a[is="moz-support-link"]:not(.sidebar-footer-link) {
}

html|dialog {
padding: 24px;
padding: var(--space-xlarge);
}

html|dialog::backdrop,
Expand Down Expand Up @@ -717,7 +717,7 @@ html|dialog,
border-radius: 50%;
border: 1px solid transparent;
list-style-image: url(chrome://browser/skin/fxa/avatar-color.svg);
margin-inline-end: 24px;
margin-inline-end: var(--space-xlarge);
-moz-user-focus: normal;
}

Expand Down Expand Up @@ -803,7 +803,7 @@ html|dialog,
}

.sync-group {
margin-block: 16px;
margin-block: var(--space-large);
border: 1px solid var(--in-content-border-color);
}

Expand All @@ -818,7 +818,7 @@ html|dialog,
.sync-engines-list > div,
.sync-engines-list + hbox {
margin-top: 0;
padding-top: 16px;
padding-top: var(--space-large);
max-width: 300px;
height: auto;
}
Expand Down Expand Up @@ -961,7 +961,7 @@ dialog > .sync-engines-list + hbox {
}

#policies-container {
margin-inline-end: 16px;
margin-inline-end: var(--space-large);
/* Make sure the container is at least the same height as the searchbox.
This is needed in addition to the min-height above to make the info icon
the same height as the first line in the policies label.
Expand Down Expand Up @@ -1217,11 +1217,11 @@ richlistitem .text-link:hover {
}

#pane-experimental-featureGates {
margin-top: 16px;
margin-top: var(--space-large);
}

.featureGate {
margin-bottom: 16px;
margin-bottom: var(--space-large);
}

.featureGateCheckbox {
Expand Down Expand Up @@ -1251,7 +1251,7 @@ richlistitem .text-link:hover {
}

#moreFromMozillaCategory-header .subtitle {
margin-block-end: 24px;
margin-block-end: var(--space-xlarge);
}

#moreFromMozillaCategory:not([hidden]) {
Expand Down Expand Up @@ -1358,7 +1358,7 @@ richlistitem .text-link:hover {
}

.simple .qr-code-box {
padding-inline: 24px;
padding-inline: var(--space-xlarge);
padding-block: 20px
}

Expand Down Expand Up @@ -1387,13 +1387,13 @@ richlistitem .text-link:hover {
#web-appearance-chooser {
display: flex;
justify-content: space-between;
gap: 16px;
gap: var(--space-large);
}

#web-appearance-chooser,
#web-appearance-override-warning,
#text-zoom-override-warning {
margin: 12px 0;
margin: var(--space-medium) 0;
}

#web-appearance-override-warning:not([hidden]) {
Expand All @@ -1411,7 +1411,7 @@ richlistitem .text-link:hover {

.web-appearance-choice-image-container {
background-color: var(--in-content-button-background);
padding: 12px 0;
padding: var(--space-medium) 0;
}

.web-appearance-choice:hover > .web-appearance-choice-image-container {
Expand Down Expand Up @@ -1477,7 +1477,7 @@ richlistitem .text-link:hover {

#translations-manage-error {
color: var(--text-color-error);
margin: 16px 0;
margin: var(--space-large) 0;
}

.hidden-category {
Expand Down
5 changes: 4 additions & 1 deletion toolkit/themes/shared/design-system/tokens-shared.css
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,10 @@
--space-xxsmall: calc(0.5 * var(--space-xsmall));
--space-xsmall: 0.267rem;
--space-small: calc(2 * var(--space-xsmall));
--space-xlarge: calc(8 * var(--space-xsmall));
--space-medium: calc(3 * var(--space-xsmall));
--space-large: calc(4 * var(--space-xsmall));
--space-xlarge: calc(6 * var(--space-xsmall));
--space-xxlarge: calc(8 * var(--space-xsmall));
}
}

Expand Down

0 comments on commit a10c268

Please sign in to comment.