Bug 1706346 part 3 - [css-lists] Remove the internal '-moz-list-rever…

…sed' CSS property that is no longer needed. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D129957
dothq · Nov 14, 2021 · a36baa4 · a36baa4
1 parent b103892
commit a36baa4
Show file tree

Hide file tree

Showing 15 changed files with 2 additions and 61 deletions.
diff --git a/devtools/server/actors/animation-type-longhand.js b/devtools/server/actors/animation-type-longhand.js
@@ -98,7 +98,6 @@ exports.ANIMATION_TYPE_FOR_LONGHANDS = [
       "list-style-image",
       "list-style-position",
       "list-style-type",
-      "-moz-list-reversed",
       "marker-end",
       "marker-mid",
       "marker-start",

diff --git a/layout/style/ServoBindings.toml b/layout/style/ServoBindings.toml
@@ -498,7 +498,6 @@ cbindgen-types = [
     { gecko = "StyleTextDecorationLine", servo = "crate::values::computed::TextDecorationLine" },
     { gecko = "StyleTextTransform", servo = "crate::values::computed::TextTransform" },
     { gecko = "StyleTextUnderlinePosition", servo = "crate::values::computed::TextUnderlinePosition" },
-    { gecko = "StyleMozListReversed", servo = "crate::values::computed::MozListReversed" },
     { gecko = "StyleOwned", servo = "crate::gecko_bindings::sugar::ownership::Owned" },
     { gecko = "StyleOwnedOrNull", servo = "crate::gecko_bindings::sugar::ownership::OwnedOrNull" },
     { gecko = "StyleStrong", servo = "crate::gecko_bindings::sugar::ownership::Strong" },

diff --git a/layout/style/nsStyleStruct.cpp b/layout/style/nsStyleStruct.cpp
@@ -584,8 +584,7 @@ nsStyleList::nsStyleList(const Document& aDocument)
     : mListStylePosition(NS_STYLE_LIST_STYLE_POSITION_OUTSIDE),
       mQuotes(StyleQuotes::Auto()),
       mListStyleImage(StyleImage::None()),
-      mImageRegion(StyleClipRectOrAuto::Auto()),
-      mMozListReversed(StyleMozListReversed::False) {
+      mImageRegion(StyleClipRectOrAuto::Auto()) {
   MOZ_COUNT_CTOR(nsStyleList);
   MOZ_ASSERT(NS_IsMainThread());
 
@@ -599,8 +598,7 @@ nsStyleList::nsStyleList(const nsStyleList& aSource)
       mCounterStyle(aSource.mCounterStyle),
       mQuotes(aSource.mQuotes),
       mListStyleImage(aSource.mListStyleImage),
-      mImageRegion(aSource.mImageRegion),
-      mMozListReversed(aSource.mMozListReversed) {
+      mImageRegion(aSource.mImageRegion) {
   MOZ_COUNT_CTOR(nsStyleList);
 }
 
@@ -635,11 +633,6 @@ nsChangeHint nsStyleList::CalcDifference(
              mCounterStyle != aNewData.mCounterStyle) {
     hint = nsChangeHint_NeutralChange;
   }
-  // This is an internal UA-sheet property that is true only for <ol reversed>
-  // so hopefully it changes rarely.
-  if (mMozListReversed != aNewData.mMozListReversed) {
-    return NS_STYLE_HINT_REFLOW;
-  }
   // list-style-image and -moz-image-region may affect some XUL elements
   // regardless of display value, so we still need to check them.
   if (mListStyleImage != aNewData.mListStyleImage) {

diff --git a/layout/style/nsStyleStruct.h b/layout/style/nsStyleStruct.h
@@ -685,8 +685,6 @@ struct MOZ_NEEDS_MEMMOVABLE_MEMBERS nsStyleList {
 
   // the rect to use within an image.
   mozilla::StyleClipRectOrAuto mImageRegion;
-  // true in an <ol reversed> scope.
-  mozilla::StyleMozListReversed mMozListReversed;
 };
 
 struct MOZ_NEEDS_MEMMOVABLE_MEMBERS nsStylePage {

diff --git a/layout/style/res/html.css b/layout/style/res/html.css
@@ -588,11 +588,6 @@ ul, menu, dir {
 
 ul, ol, menu {
   counter-reset: list-item;
-  -moz-list-reversed: false;
-}
-
-ol[reversed] {
-  -moz-list-reversed: true;
 }
 
 ol {

diff --git a/layout/style/test/ListCSSProperties.cpp b/layout/style/test/ListCSSProperties.cpp
@@ -95,7 +95,6 @@ const char* gInaccessibleProperties[] = {
     "-x-text-zoom",
     "-moz-default-appearance",
     "-moz-inert",
-    "-moz-list-reversed",  // parsed by UA sheets only
     "-moz-script-level",   // parsed by UA sheets only
     "-moz-script-size-multiplier",
     "-moz-script-min-size",

diff --git a/layout/style/test/test_non_content_accessible_properties.html b/layout/style/test/test_non_content_accessible_properties.html
@@ -8,7 +8,6 @@
   "-x-span",
   "-x-lang",
   "-x-text-zoom",
-  "-moz-list-reversed",
   "-moz-window-shadow",
   "-moz-window-opacity",
   "-moz-window-transform",

diff --git a/servo/components/style/properties/data.py b/servo/components/style/properties/data.py
@@ -486,7 +486,6 @@ def specified_is_copy(self):
                 "MasonryAutoFlow",
                 "MozForceBrokenImageIcon",
                 "text::MozControlCharacterVisibility",
-                "MozListReversed",
                 "MathDepth",
                 "MozScriptMinSize",
                 "MozScriptSizeMultiplier",

diff --git a/servo/components/style/properties/longhands/list.mako.rs b/servo/components/style/properties/longhands/list.mako.rs
@@ -83,14 +83,3 @@ ${helpers.predefined_type(
     boxed=True,
     spec="Nonstandard (https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-image-region)",
 )}
-
-${helpers.predefined_type(
-    "-moz-list-reversed",
-    "MozListReversed",
-    "computed::MozListReversed::False",
-    engines="gecko",
-    animation_value_type="discrete",
-    enabled_in="ua",
-    spec="Internal implementation detail for <ol reversed>",
-    servo_restyle_damage="rebuild_and_reflow",
-)}
diff --git a/servo/components/style/values/computed/list.rs b/servo/components/style/values/computed/list.rs
@@ -6,7 +6,6 @@
 
 #[cfg(feature = "gecko")]
 pub use crate::values::specified::list::ListStyleType;
-pub use crate::values::specified::list::MozListReversed;
 pub use crate::values::specified::list::Quotes;
 
 impl Quotes {

diff --git a/servo/components/style/values/computed/mod.rs b/servo/components/style/values/computed/mod.rs
@@ -67,7 +67,6 @@ pub use self::length::{LengthOrAuto, LengthPercentageOrAuto, MaxSize, Size};
 pub use self::length::{NonNegativeLengthPercentage, NonNegativeLengthPercentageOrAuto};
 #[cfg(feature = "gecko")]
 pub use self::list::ListStyleType;
-pub use self::list::MozListReversed;
 pub use self::list::Quotes;
 pub use self::motion::{OffsetPath, OffsetRotate};
 pub use self::outline::OutlineStyle;

diff --git a/servo/components/style/values/specified/list.rs b/servo/components/style/values/specified/list.rs
@@ -199,27 +199,3 @@ impl Parse for Quotes {
         }
     }
 }
-
-/// Specified and computed `-moz-list-reversed` property (for UA sheets only).
-#[derive(
-    Clone,
-    Copy,
-    Debug,
-    Eq,
-    Hash,
-    MallocSizeOf,
-    Parse,
-    PartialEq,
-    SpecifiedValueInfo,
-    ToComputedValue,
-    ToCss,
-    ToResolvedValue,
-    ToShmem,
-)]
-#[repr(u8)]
-pub enum MozListReversed {
-    /// the initial value
-    False,
-    /// exclusively used for <ol reversed> in our html.css UA sheet
-    True,
-}
diff --git a/servo/components/style/values/specified/mod.rs b/servo/components/style/values/specified/mod.rs
@@ -66,7 +66,6 @@ pub use self::length::{
 };
 #[cfg(feature = "gecko")]
 pub use self::list::ListStyleType;
-pub use self::list::MozListReversed;
 pub use self::list::Quotes;
 pub use self::motion::{OffsetPath, OffsetRotate};
 pub use self::outline::OutlineStyle;

diff --git a/servo/ports/geckolib/cbindgen.toml b/servo/ports/geckolib/cbindgen.toml
@@ -157,7 +157,6 @@ include = [
   "TextOverflow",
   "MozControlCharacterVisibility",
   "RubyPosition",
-  "MozListReversed",
   "Owned",
   "OwnedOrNull",
   "Strong",

diff --git a/toolkit/content/minimal-xul.css b/toolkit/content/minimal-xul.css
@@ -44,7 +44,6 @@
     pointer-events: inherit;
 
     /* These properties are not included in 'all'. */
-    -moz-list-reversed: initial;
     -moz-context-properties: initial;
     -moz-control-character-visibility: initial;
     -moz-font-smoothing-background-color: initial;