Skip to content

Commit

Permalink
Bug 1699696 - Stopgap mips64 implementation of isValidStackMapKey. r=…
Browse files Browse the repository at this point in the history
…nbp DONTBUILD

Without this fix, no baseline compiler tests pass.  Bug remains open,
a more comprehensive fix can be added later.

Differential Revision: https://phabricator.services.mozilla.com/D109071
  • Loading branch information
Lars T Hansen committed Mar 22, 2021
1 parent 8ebd267 commit a370d8c
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions js/src/wasm/WasmBaselineCompile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -17524,6 +17524,10 @@ bool js::wasm::IsValidStackMapKey(bool debugEnabled, const uint8_t* nextPC) {
(insn[-1] & 0xfc000000) == 0x94000000 || // bl simm26
(debugEnabled && insn[-1] == 0xd503201f)); // nop

# elif defined(JS_CODEGEN_MIPS64)
// TODO (bug 1699696): Implement this. As for the platforms above, we need to
// enumerate all code sequences that can precede the stack map location.
return true;
# else
MOZ_CRASH("IsValidStackMapKey: requires implementation on this platform");
# endif
Expand Down

0 comments on commit a370d8c

Please sign in to comment.