Skip to content

Commit

Permalink
Bug 939071 - Kill SHORT_LIBNAME. r=ted
Browse files Browse the repository at this point in the history
  • Loading branch information
glandium committed Nov 19, 2013
1 parent b2e90f6 commit a58f736
Show file tree
Hide file tree
Showing 12 changed files with 2 additions and 37 deletions.
1 change: 0 additions & 1 deletion browser/components/build/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

SHORT_LIBNAME = brwsrcmp
MODULE_NAME = nsBrowserCompsModule

ifeq ($(OS_ARCH),WINNT)
Expand Down
5 changes: 1 addition & 4 deletions config/config.mk
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ _MOZBUILD_EXTERNAL_VARIABLES := \
_DEPRECATED_VARIABLES := \
MOCHITEST_FILES_PARTS \
MOCHITEST_BROWSER_FILES_PARTS \
SHORT_LIBNAME \
$(NULL)

ifndef EXTERNALLY_MANAGED_MAKE_FILE
Expand Down Expand Up @@ -134,7 +135,6 @@ CHECK_VARS := \
LIBRARY_NAME \
MODULE \
DEPTH \
SHORT_LIBNAME \
XPI_PKGNAME \
INSTALL_EXTENSION_ID \
SHARED_LIBRARY_NAME \
Expand Down Expand Up @@ -341,9 +341,6 @@ ifdef MODULE_NAME
$(error MODULE_NAME is $(MODULE_NAME) but MODULE_NAME and LIBXUL_LIBRARY are not compatible)
endif
FORCE_STATIC_LIB=1
ifneq ($(SHORT_LIBNAME),)
$(error SHORT_LIBNAME is $(SHORT_LIBNAME) but SHORT_LIBNAME is not compatable with LIBXUL_LIBRARY)
endif
endif

# If we are building this component into an extension/xulapp, it cannot be
Expand Down
7 changes: 0 additions & 7 deletions config/rules.mk
Original file line number Diff line number Diff line change
Expand Up @@ -212,12 +212,6 @@ ifneq (,$(filter OS2 WINNT,$(OS_ARCH)))
IMPORT_LIBRARY := $(LIB_PREFIX)$(SHARED_LIBRARY_NAME).$(IMPORT_LIB_SUFFIX)
endif

ifeq (OS2,$(OS_ARCH))
ifdef SHORT_LIBNAME
SHARED_LIBRARY_NAME := $(SHORT_LIBNAME)
endif
endif

ifdef MAKE_FRAMEWORK
SHARED_LIBRARY := $(SHARED_LIBRARY_NAME)
else
Expand Down Expand Up @@ -1689,7 +1683,6 @@ FREEZE_VARIABLES = \
DIRS \
LIBRARY \
MODULE \
SHORT_LIBNAME \
TIERS \
EXTRA_COMPONENTS \
EXTRA_PP_COMPONENTS \
Expand Down
1 change: 0 additions & 1 deletion db/sqlite3/src/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

SHORT_LIBNAME = mozsqlt3
LIB_IS_C_ONLY = 1

ifeq ($(OS_ARCH),WINNT)
Expand Down
2 changes: 0 additions & 2 deletions extensions/gnomevfs/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

SHORT_LIBNAME = nkgnomevfs

LOCAL_INCLUDES = $(MOZ_GNOMEVFS_CFLAGS)

EXTRA_DSO_LDOPTS = \
Expand Down
2 changes: 0 additions & 2 deletions extensions/widgetutils/src/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

SHORT_LIBNAME = widgetutils

EXTRA_DSO_LDOPTS = \
$(XPCOM_GLUE_LDOPTS) \
$(NSPR_LIBS) \
Expand Down
5 changes: 1 addition & 4 deletions js/src/config/config.mk
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ _MOZBUILD_EXTERNAL_VARIABLES := \
_DEPRECATED_VARIABLES := \
MOCHITEST_FILES_PARTS \
MOCHITEST_BROWSER_FILES_PARTS \
SHORT_LIBNAME \
$(NULL)

ifndef EXTERNALLY_MANAGED_MAKE_FILE
Expand Down Expand Up @@ -134,7 +135,6 @@ CHECK_VARS := \
LIBRARY_NAME \
MODULE \
DEPTH \
SHORT_LIBNAME \
XPI_PKGNAME \
INSTALL_EXTENSION_ID \
SHARED_LIBRARY_NAME \
Expand Down Expand Up @@ -341,9 +341,6 @@ ifdef MODULE_NAME
$(error MODULE_NAME is $(MODULE_NAME) but MODULE_NAME and LIBXUL_LIBRARY are not compatible)
endif
FORCE_STATIC_LIB=1
ifneq ($(SHORT_LIBNAME),)
$(error SHORT_LIBNAME is $(SHORT_LIBNAME) but SHORT_LIBNAME is not compatable with LIBXUL_LIBRARY)
endif
endif

# If we are building this component into an extension/xulapp, it cannot be
Expand Down
7 changes: 0 additions & 7 deletions js/src/config/rules.mk
Original file line number Diff line number Diff line change
Expand Up @@ -212,12 +212,6 @@ ifneq (,$(filter OS2 WINNT,$(OS_ARCH)))
IMPORT_LIBRARY := $(LIB_PREFIX)$(SHARED_LIBRARY_NAME).$(IMPORT_LIB_SUFFIX)
endif

ifeq (OS2,$(OS_ARCH))
ifdef SHORT_LIBNAME
SHARED_LIBRARY_NAME := $(SHORT_LIBNAME)
endif
endif

ifdef MAKE_FRAMEWORK
SHARED_LIBRARY := $(SHARED_LIBRARY_NAME)
else
Expand Down Expand Up @@ -1689,7 +1683,6 @@ FREEZE_VARIABLES = \
DIRS \
LIBRARY \
MODULE \
SHORT_LIBNAME \
TIERS \
EXTRA_COMPONENTS \
EXTRA_PP_COMPONENTS \
Expand Down
1 change: 0 additions & 1 deletion media/libsoundtouch/src/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

SHORT_LIBNAME = soundt
EXTRA_DSO_LDOPTS += $(MOZALLOC_LIB)

# Use abort() instead of exception in SoundTouch.
Expand Down
2 changes: 0 additions & 2 deletions toolkit/components/ctypes/tests/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

SHORT_LIBNAME = jscttest

LOCAL_INCLUDES = \
-I$(topsrcdir)/js/src/ctypes \
$(NULL)
Expand Down
4 changes: 0 additions & 4 deletions xpcom/sample/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

# On OS/2, SHORT_LIBNAME is used to generate a library with an 8.3 filename,
# e.g. dist/bin/components/xpcomsmp.dll
SHORT_LIBNAME = xpcomsmp

# If this is Makefile builds a component, MODULE_NAME must match the module
# name specified in NS_IMPL_NSGETMODULE
MODULE_NAME = nsSampleModule
Expand Down
2 changes: 0 additions & 2 deletions xulrunner/examples/simple/components/src/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

SHORT_LIBNAME = simpltst

EXTRA_DSO_LDOPTS = \
$(XPCOM_GLUE_LDOPTS) \
$(NSPR_LIBS) \
Expand Down

0 comments on commit a58f736

Please sign in to comment.