Skip to content

Commit

Permalink
Bug 1879225: Remove obsolete argument r=dminor
Browse files Browse the repository at this point in the history
The RegExpCompiler stores the flags internally, so there isn't any need to pass them in here. Upstream V8 fixed the API.

Differential Revision: https://phabricator.services.mozilla.com/D201919
  • Loading branch information
iainireland committed Feb 28, 2024
1 parent 6661d7f commit a5d7741
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion js/src/irregexp/RegExpAPI.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,7 @@ bool CompilePattern(JSContext* cx, MutableHandleRegExpShared re,
bool isLatin1 = input->hasLatin1Chars();

SampleCharacters(input, compiler);
data.node = compiler.PreprocessRegExp(&data, flags, isLatin1);
data.node = compiler.PreprocessRegExp(&data, isLatin1);
data.error = AnalyzeRegExp(cx->isolate, isLatin1, flags, data.node);
if (data.error != RegExpError::kNone) {
MOZ_ASSERT(data.error == RegExpError::kAnalysisStackOverflow);
Expand Down

0 comments on commit a5d7741

Please sign in to comment.