Bug 1691814 - [remote] Improve failure message for timestamp assertio…

…ns. r=remote-protocol-reviewers,jdescottes Differential Revision: https://phabricator.services.mozilla.com/D104578
dothq · Feb 13, 2021 · a8048b6 · a8048b6
1 parent 198eb87
commit a8048b6
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 11 deletions.
diff --git a/remote/test/browser/page/browser_domContentEventFired.js b/remote/test/browser/page/browser_domContentEventFired.js
@@ -82,10 +82,10 @@ async function runContentEventFiredTest(client, expectedEventCount, callback) {
     },
   });
 
-  const timeStart = Date.now() / 1000;
+  const timeBefore = Date.now() / 1000;
   await callback();
   const domContentEventFiredEvents = await history.record();
-  const timeEnd = Date.now() / 1000;
+  const timeAfter = Date.now() / 1000;
 
   is(
     domContentEventFiredEvents.length,
@@ -98,7 +98,7 @@ async function runContentEventFiredTest(client, expectedEventCount, callback) {
 
   const timestamp = domContentEventFiredEvents[0].payload.timestamp;
   ok(
-    timestamp >= timeStart && timestamp <= timeEnd,
-    `Timestamp in expected range [${timeStart} - ${timeEnd}]`
+    timestamp >= timeBefore && timestamp <= timeAfter,
+    `Timestamp ${timestamp} in expected range [${timeBefore} - ${timeAfter}]`
   );
 }
diff --git a/remote/test/browser/page/browser_loadEventFired.js b/remote/test/browser/page/browser_loadEventFired.js
@@ -82,10 +82,10 @@ async function runLoadEventFiredTest(client, expectedEventCount, callback) {
     },
   });
 
-  const timeStart = Date.now() / 1000;
+  const timeBefore = Date.now() / 1000;
   await callback();
   const loadEventFiredEvents = await history.record();
-  const timeEnd = Date.now() / 1000;
+  const timeAfter = Date.now() / 1000;
 
   is(
     loadEventFiredEvents.length,
@@ -98,7 +98,7 @@ async function runLoadEventFiredTest(client, expectedEventCount, callback) {
 
   const timestamp = loadEventFiredEvents[0].payload.timestamp;
   ok(
-    timestamp >= timeStart && timestamp <= timeEnd,
-    `Timestamp in expected range [${timeStart} - ${timeEnd}]`
+    timestamp >= timeBefore && timestamp <= timeAfter,
+    `Timestamp ${timestamp} in expected range [${timeBefore} - ${timeAfter}]`
   );
 }
diff --git a/remote/test/browser/runtime/browser_consoleAPICalled.js b/remote/test/browser/runtime/browser_consoleAPICalled.js
@@ -176,9 +176,11 @@ async function runConsoleTest(client, eventCount, callback, options = {}) {
 
   // Check basic details for consoleAPICalled events
   consoleAPIentries.forEach(({ payload }) => {
+    const timestamp = payload.timestamp;
+
     ok(
-      payload.timestamp >= timeBefore && payload.timestamp <= timeAfter,
-      "Got valid timestamp"
+      timestamp >= timeBefore && timestamp <= timeAfter,
+      `Timestamp ${timestamp} in expected range [${timeBefore} - ${timeAfter}]`
     );
   });
 

diff --git a/remote/test/browser/runtime/browser_exceptionThrown.js b/remote/test/browser/runtime/browser_exceptionThrown.js
@@ -112,7 +112,7 @@ async function runExceptionThrownTest(
     is(typeof details, "object", "Got expected 'exceptionDetails' property");
     ok(
       timestamp >= timeBefore && timestamp <= timeAfter,
-      "Got valid timestamp"
+      `Timestamp ${timestamp} in expected range [${timeBefore} - ${timeAfter}]`
     );
   });