Bug 1881486 - [devtools] Don't linkify empty attributes. r=devtools-r…

…eviewers,ochameau. Differential Revision: https://phabricator.services.mozilla.com/D202452
dothq · Feb 27, 2024 · a948bc7 · a948bc7
1 parent 528d050
commit a948bc7
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/devtools/client/inspector/markup/test/browser_markup_links_aria_attributes.js b/devtools/client/inspector/markup/test/browser_markup_links_aria_attributes.js
@@ -85,6 +85,16 @@ const TEST_DATA = [
     attributeName: "aria-describedby",
     links: [{ id: "describedby01", valid: false }, { id: "describedbyshadow" }],
   },
+  {
+    selector: "#empty-attributes",
+    attributeName: "aria-activedescendant",
+    links: [],
+  },
+  {
+    selector: "#empty-attributes",
+    attributeName: "aria-details",
+    links: [],
+  },
 ];
 
 add_task(async function () {

diff --git a/devtools/client/inspector/markup/test/doc_markup_links_aria_attributes.html b/devtools/client/inspector/markup/test/doc_markup_links_aria_attributes.html
@@ -60,5 +60,7 @@
     <div id="owns02">#owns02</div>
 
     <test-component></test-component>
+
+    <div id="empty-attributes" aria-activedescendant=" " aria-details="  "></div>
   </body>
 </html>
diff --git a/devtools/client/inspector/markup/views/element-editor.js b/devtools/client/inspector/markup/views/element-editor.js
@@ -878,7 +878,7 @@ ElementEditor.prototype = {
 
     // Create links in the attribute value, and truncate long attribute values if needed.
     for (const token of parsedLinksData) {
-      if (token.type === "string") {
+      if (token.type === "string" || token.value?.trim() === "") {
         attributeValueEl.appendChild(
           this.doc.createTextNode(this._truncateAttributeValue(token.value))
         );