Skip to content

Commit

Permalink
Bug 816784 part 4 - Fix the rooting hazards that the analysis report.…
Browse files Browse the repository at this point in the history
… r=sfink

WrapperMap::Enum::goToNext() is listed as a GC function because the *generated*
stack calls BrowserCompartmentMatcher::match() which leads a path to a FieldCall
of nsISupports.QueryInterface, however it is never the case. Add
nsContentUtils::IsExpandedPrincipal() to the ignore functions because it is more
narrowly scoped and therefore less likely to hide problems.



MozReview-Commit-ID: ACwkMtRiQk2

--HG--
extra : rebase_source : 2cadcc9f59096b4e5f693f39e2cab93da048f949
  • Loading branch information
janus926 committed May 23, 2017
1 parent 13ae780 commit a9760d2
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions js/src/devtools/rootAnalysis/annotations.js
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,8 @@ var ignoreFunctions = {
// The big hammers.
"PR_GetCurrentThread" : true,
"calloc" : true,

"uint8 nsContentUtils::IsExpandedPrincipal(nsIPrincipal*)" : true,
};

function extraGCFunctions() {
Expand Down

0 comments on commit a9760d2

Please sign in to comment.