Bug 1557645 - Document::CreateStaticClone shouldn't be virtual. r=jwatt

Just minor preliminar cleanup. Differential Revision: https://phabricator.services.mozilla.com/D90314
dothq · Sep 15, 2020 · ad97bae · ad97bae
1 parent 7da05af
commit ad97bae
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/dom/base/Document.cpp b/dom/base/Document.cpp
@@ -12283,8 +12283,10 @@ already_AddRefed<Document> Document::CreateStaticClone(
   });
 
   // Make document use different container during cloning.
+  //
+  // FIXME(emilio): Why is this needed?
   RefPtr<nsDocShell> originalShell = mDocumentContainer.get();
-  SetContainer(static_cast<nsDocShell*>(aCloneContainer));
+  SetContainer(nsDocShell::Cast(aCloneContainer));
   IgnoredErrorResult rv;
   nsCOMPtr<nsINode> clonedNode = this->CloneNode(true, rv);
   SetContainer(originalShell);

diff --git a/dom/base/Document.h b/dom/base/Document.h
@@ -2831,8 +2831,7 @@ class Document : public nsINode,
    *
    * @param aCloneContainer The container for the clone document.
    */
-  virtual already_AddRefed<Document> CreateStaticClone(
-      nsIDocShell* aCloneContainer);
+  already_AddRefed<Document> CreateStaticClone(nsIDocShell* aCloneContainer);
 
   /**
    * If this document is a static clone, this returns the original