Bug 1747165 - Replace TK_FLAGS/TK_LIBS with MOZ_GTK3_FLAGS/MOZ_GTK3_L…

…IBS. r=firefox-build-system-reviewers,andi

Differential Revision: https://phabricator.services.mozilla.com/D134464

accessible/atk/moz.build

@@ -50,8 +50,8 @@ LOCAL_INCLUDES += [
 FINAL_LIBRARY = "xul"
 
 if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
-    CFLAGS += CONFIG["TK_CFLAGS"]
-    CXXFLAGS += CONFIG["TK_CFLAGS"]
+    CFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
 
 if CONFIG["MOZ_ENABLE_DBUS"]:
     CXXFLAGS += CONFIG["MOZ_DBUS_CFLAGS"]

browser/components/shell/moz.build

@@ -81,7 +81,9 @@ for var in (
 ):
     DEFINES[var] = '"%s"' % CONFIG[var]
 
-CXXFLAGS += CONFIG["TK_CFLAGS"]
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
+
 if CONFIG["MOZ_ENABLE_DBUS"]:
     CXXFLAGS += CONFIG["MOZ_DBUS_GLIB_CFLAGS"]
 

chrome/moz.build

@@ -41,7 +41,7 @@ LOCAL_INCLUDES += [
 ]
 
 if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
-    CXXFLAGS += CONFIG["TK_CFLAGS"]
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
 
 with Files("**"):
     BUG_COMPONENT = ("Toolkit", "Startup and Profile System")

dom/base/moz.build

@@ -573,8 +573,8 @@ include("/ipc/chromium/chromium-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
 
-if CONFIG["MOZ_X11"]:
-    CXXFLAGS += CONFIG["TK_CFLAGS"]
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
 
 GeneratedFile(
     "UseCounterList.h",

dom/canvas/moz.build

@@ -202,7 +202,8 @@ LOCAL_INCLUDES += [
     "/media/libyuv/libyuv/include",
 ]
 
-CXXFLAGS += CONFIG["TK_CFLAGS"]
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
 
 LOCAL_INCLUDES += CONFIG["SKIA_INCLUDES"]
 

dom/file/ipc/moz.build

@@ -65,7 +65,8 @@ include("/tools/fuzzing/libfuzzer-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
 
-CXXFLAGS += CONFIG["TK_CFLAGS"]
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
 
 BROWSER_CHROME_MANIFESTS += ["tests/browser.ini"]
 MOCHITEST_MANIFESTS += ["tests/mochitest.ini"]

dom/ipc/moz.build

@@ -247,7 +247,8 @@ MOCHITEST_CHROME_MANIFESTS += ["tests/chrome.ini"]
 MOCHITEST_MANIFESTS += ["tests/mochitest.ini"]
 XPCSHELL_TESTS_MANIFESTS += ["tests/xpcshell.ini"]
 
-CXXFLAGS += CONFIG["TK_CFLAGS"]
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
 
 if CONFIG["FUZZING"] and CONFIG["FUZZING_INTERFACES"]:
     TEST_DIRS += ["fuzztest"]

dom/media/platforms/ffmpeg/ffmpeg58/moz.build

@@ -26,7 +26,7 @@ if CONFIG['CC_TYPE'] == 'gcc':
     '-Wno-attributes',
   ]
 if CONFIG['MOZ_WAYLAND']:
-  CXXFLAGS += CONFIG['TK_CFLAGS']
+  CXXFLAGS += CONFIG['MOZ_GTK3_CFLAGS']
   DEFINES['MOZ_WAYLAND_USE_VAAPI'] = 1
   UNIFIED_SOURCES += [
     '../FFmpegVideoFramePool.cpp',

dom/media/platforms/ffmpeg/ffvpx/moz.build

@@ -37,7 +37,7 @@ DEFINES["FFVPX_VERSION"] = 46465650
 DEFINES["USING_MOZFFVPX"] = True
 
 if CONFIG["MOZ_WAYLAND"]:
-    CXXFLAGS += CONFIG["TK_CFLAGS"]
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
     DEFINES["MOZ_WAYLAND_USE_VAAPI"] = 1
 
 FINAL_LIBRARY = "xul"

dom/plugins/base/moz.build

@@ -41,4 +41,5 @@ include("/ipc/chromium/chromium-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
 
-CXXFLAGS += CONFIG["TK_CFLAGS"]
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]

gfx/gl/moz.build

@@ -150,8 +150,9 @@ FINAL_LIBRARY = "xul"
 if CONFIG["MOZ_D3DCOMPILER_VISTA_DLL"]:
     DEFINES["MOZ_D3DCOMPILER_VISTA_DLL"] = CONFIG["MOZ_D3DCOMPILER_VISTA_DLL"]
 
-CXXFLAGS += CONFIG["TK_CFLAGS"]
-CFLAGS += CONFIG["TK_CFLAGS"]
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
+    CFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
 
 CXXFLAGS += ["-Werror=switch"]
 

gfx/ipc/moz.build

@@ -79,7 +79,9 @@ include("/ipc/chromium/chromium-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
 
-CXXFLAGS += CONFIG["TK_CFLAGS"]
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
+
 CXXFLAGS += ["-Werror=switch"]
 
 LOCAL_INCLUDES += CONFIG["SKIA_INCLUDES"]

gfx/layers/moz.build

@@ -495,7 +495,9 @@ if CONFIG["ENABLE_TESTS"]:
 MOCHITEST_MANIFESTS += ["apz/test/mochitest/mochitest.ini"]
 BROWSER_CHROME_MANIFESTS += ["apz/test/mochitest/browser.ini"]
 
-CXXFLAGS += CONFIG["TK_CFLAGS"]
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
+
 CXXFLAGS += ["-Werror=switch"]
 
 LOCAL_INCLUDES += CONFIG["SKIA_INCLUDES"]

gfx/src/moz.build

@@ -91,7 +91,6 @@ LOCAL_INCLUDES += [
 
 FINAL_LIBRARY = "xul"
 
-CXXFLAGS += CONFIG["TK_CFLAGS"]
-
 if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
     CXXFLAGS += CONFIG["MOZ_PANGO_CFLAGS"]

gfx/thebes/moz.build

@@ -272,13 +272,12 @@ if CONFIG["MOZ_WIDGET_TOOLKIT"] == "windows":
         if CONFIG[var]:
             DEFINES[var] = True
 
-CXXFLAGS += CONFIG["TK_CFLAGS"]
-CFLAGS += CONFIG["TK_CFLAGS"]
-
 if CONFIG["MOZ_WIDGET_TOOLKIT"] in ("android"):
     CXXFLAGS += CONFIG["CAIRO_FT_CFLAGS"]
 
 if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
+    CFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
     CXXFLAGS += CONFIG["MOZ_PANGO_CFLAGS"]
 
 if CONFIG["MOZ_WAYLAND"]:

gfx/vr/moz.build

@@ -91,8 +91,9 @@ if CONFIG["OS_ARCH"] == "WINNT":
     LOCAL_INCLUDES += ["/layout/generic", "/widget", "/widget/windows"]
     SOURCES += ["FxROutputHandler.cpp", "FxRWindowManager.cpp"]
 
-CXXFLAGS += CONFIG["TK_CFLAGS"]
-CFLAGS += CONFIG["TK_CFLAGS"]
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
+    CFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
 
 include("/ipc/chromium/chromium-config.mozbuild")
 

gfx/webrender_bindings/moz.build

@@ -124,5 +124,7 @@ FINAL_LIBRARY = "xul"
 LOCAL_INCLUDES += [
     "/gfx/cairo/cairo/src",
 ]
-CXXFLAGS += CONFIG["TK_CFLAGS"]
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
+
 CXXFLAGS += ["-Werror=switch"]

image/decoders/icon/gtk/moz.build

@@ -14,6 +14,7 @@ EXPORTS += [
 
 FINAL_LIBRARY = "xul"
 
-CXXFLAGS += CONFIG["TK_CFLAGS"]
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
 
 include("/ipc/chromium/chromium-config.mozbuild")

ipc/chromium/moz.build

@@ -123,7 +123,8 @@ if os_solaris:
         "src/base/time_posix.cc",
     ]
 
-CXXFLAGS += CONFIG["TK_CFLAGS"]
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
 
 TEST_DIRS += [
     "gtest",

ipc/ipdl/moz.build

@@ -15,7 +15,8 @@ FINAL_LIBRARY = "xul"
 
 # We #include some things in the dom/plugins/ directory that rely on
 # toolkit libraries.
-CXXFLAGS += CONFIG["TK_CFLAGS"]
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
 
 # Add libFuzzer configuration directives
 include("/tools/fuzzing/libfuzzer-config.mozbuild")

js/xpconnect/shell/moz.build

@@ -68,6 +68,7 @@ if CONFIG["OS_TARGET"] == "Darwin":
         "-framework Foundation",
     ]
 
-CFLAGS += CONFIG["TK_CFLAGS"]
-CXXFLAGS += CONFIG["TK_CFLAGS"]
-OS_LIBS += CONFIG["TK_LIBS"]
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
+    OS_LIBS += CONFIG["MOZ_GTK3_LIBS"]

layout/generic/moz.build

@@ -266,4 +266,4 @@ MOCHITEST_MANIFESTS += ["test/mochitest.ini"]
 MOCHITEST_CHROME_MANIFESTS += ["test/chrome.ini"]
 
 if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
-    CXXFLAGS += CONFIG["TK_CFLAGS"]
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]

layout/xul/moz.build

@@ -53,8 +53,9 @@ UNIFIED_SOURCES += [
 
 DIRS += ["tree"]
 
-CFLAGS += CONFIG["TK_CFLAGS"]
-CXXFLAGS += CONFIG["TK_CFLAGS"]
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
 
 include("/ipc/chromium/chromium-config.mozbuild")
 

netwerk/protocol/gio/moz.build

@@ -35,7 +35,8 @@ LOCAL_INCLUDES += [
 
 FINAL_LIBRARY = "xul"
 
-CXXFLAGS += CONFIG["TK_CFLAGS"]
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
 
 with Files("**"):
     BUG_COMPONENT = ("Core", "Widget: Gtk")

old-configure.in

@@ -1263,8 +1263,6 @@ esac
 if test "$COMPILE_ENVIRONMENT"; then
   if test "$MOZ_WIDGET_TOOLKIT" = gtk; then
     PKG_CHECK_MODULES(MOZ_GTK3, gtk+-3.0 >= $GTK3_VERSION gtk+-unix-print-3.0 glib-2.0 gobject-2.0 gio-unix-2.0 $GDK_PACKAGES)
-    TK_CFLAGS=$MOZ_GTK3_CFLAGS
-    TK_LIBS=$MOZ_GTK3_LIBS
     AC_DEFINE_UNQUOTED(GDK_VERSION_MIN_REQUIRED,$GDK_VERSION_MIN_REQUIRED)
     AC_DEFINE_UNQUOTED(GDK_VERSION_MAX_ALLOWED,$GDK_VERSION_MAX_ALLOWED)
   fi
@@ -1274,9 +1272,6 @@ if test "$COMPILE_ENVIRONMENT"; then
   fi
 fi # COMPILE_ENVIRONMENT
 
-AC_SUBST_LIST(TK_CFLAGS)
-AC_SUBST_LIST(TK_LIBS)
-
 dnl ========================================================
 dnl =
 dnl = Components & Features

python/mozbuild/mozbuild/gn_processor.py

@@ -471,7 +471,7 @@ def write_mozbuild(
             try:
                 if relsrcdir in write_mozbuild_variables["INCLUDE_TK_CFLAGS_DIRS"]:
                     mb.write('if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":\n')
-                    mb.write('    CXXFLAGS += CONFIG["TK_CFLAGS"]\n')
+                    mb.write('    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]\n')
             except KeyError:
                 pass
 

security/manager/ssl/tests/unit/tlsserver/cmd/moz.build

@@ -27,4 +27,5 @@ USE_LIBS += [
     "tlsserver",
 ]
 
-CXXFLAGS += CONFIG["TK_CFLAGS"]
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]

security/sandbox/linux/broker/moz.build

@@ -32,7 +32,7 @@ LOCAL_INCLUDES += [
 
 if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
     CXXFLAGS += CONFIG["GLIB_CFLAGS"]
-    CXXFLAGS += CONFIG["TK_CFLAGS"]
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
 
 FINAL_LIBRARY = "xul"
 

security/sandbox/linux/launch/moz.build

@@ -27,7 +27,8 @@ USE_LIBS += [
 ]
 
 # For the X11 socket domain inspection in SandboxLaunch:
-CXXFLAGS += CONFIG["TK_CFLAGS"]
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
 
 FINAL_LIBRARY = "xul"
 

testing/tools/screenshot/moz.build

@@ -9,8 +9,8 @@ if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk" and CONFIG["MOZ_X11"]:
     SOURCES += [
         "gdk-screenshot.cpp",
     ]
-    CXXFLAGS += CONFIG["TK_CFLAGS"]
-    OS_LIBS += CONFIG["TK_LIBS"]
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
+    OS_LIBS += CONFIG["MOZ_GTK3_LIBS"]
     if CONFIG["MOZ_ENABLE_DBUS"]:
         OS_LIBS += CONFIG["MOZ_DBUS_GLIB_LIBS"]
 

third_party/libwebrtc/api/transport/stun_types_gn/moz.build

@@ -6,7 +6,7 @@
   ### This moz.build was AUTOMATICALLY GENERATED from a GN config,  ###
   ### DO NOT edit it by hand.                                       ###
 if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
-    CXXFLAGS += CONFIG["TK_CFLAGS"]
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
 
 COMPILE_FLAGS["OS_INCLUDES"] = []
 AllowCompilerWarnings()

third_party/libwebrtc/modules/desktop_capture/desktop_capture_generic_gn/moz.build

@@ -6,7 +6,7 @@
   ### This moz.build was AUTOMATICALLY GENERATED from a GN config,  ###
   ### DO NOT edit it by hand.                                       ###
 if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
-    CXXFLAGS += CONFIG["TK_CFLAGS"]
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
 
 COMPILE_FLAGS["OS_INCLUDES"] = []
 AllowCompilerWarnings()

third_party/pipewire/libpipewire/moz.build

@@ -8,7 +8,8 @@ SOURCES += [
     'mozpipewire.cpp',
 ]
 
-CXXFLAGS += CONFIG['TK_CFLAGS']
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG['MOZ_GTK3_CFLAGS']
 
 LOCAL_INCLUDES += ['/third_party/pipewire']
 

toolkit/components/downloads/moz.build

@@ -17,7 +17,8 @@ XPIDL_SOURCES += [
 
 XPIDL_MODULE = "downloads"
 
-CXXFLAGS += CONFIG["TK_CFLAGS"]
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
 
 SOURCES += [
     "DownloadPlatform.cpp",

toolkit/components/protobuf/moz.build

@@ -142,4 +142,5 @@ if CONFIG['MOZ_USE_PTHREADS']:
 # Needed for the gzip streams.
 DEFINES['HAVE_ZLIB'] = True
 
-CXXFLAGS += CONFIG['TK_CFLAGS']
+if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
+    CXXFLAGS += CONFIG['MOZ_GTK3_CFLAGS']

toolkit/components/remote/moz.build

@@ -32,7 +32,7 @@ if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
             "nsXRemoteClient.cpp",
             "nsXRemoteServer.cpp",
         ]
-    CXXFLAGS += CONFIG["TK_CFLAGS"]
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
 
 if CONFIG["MOZ_WIDGET_TOOLKIT"] == "windows":
     SOURCES += [

toolkit/crashreporter/client/moz.build

@@ -82,9 +82,9 @@ if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
     USE_LIBS += [
         "breakpad_linux_common_s",
     ]
-    OS_LIBS += CONFIG["TK_LIBS"]
+    OS_LIBS += CONFIG["MOZ_GTK3_LIBS"]
     OS_LIBS += CONFIG["MOZ_GTHREAD_LIBS"]
-    CXXFLAGS += CONFIG["TK_CFLAGS"]
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
     CXXFLAGS += CONFIG["MOZ_GTHREAD_CFLAGS"]
 
 if CONFIG["OS_ARCH"] == "Linux" or CONFIG["OS_ARCH"] == "SunOS":

toolkit/library/moz.build

@@ -319,7 +319,7 @@ if CONFIG["MOZ_ENABLE_DBUS"]:
     OS_LIBS += CONFIG["MOZ_DBUS_GLIB_LIBS"]
 
 if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
-    OS_LIBS += [l for l in CONFIG["TK_LIBS"] if l not in ("-lgtk-3", "-lgdk-3")]
+    OS_LIBS += [l for l in CONFIG["MOZ_GTK3_LIBS"] if l not in ("-lgtk-3", "-lgdk-3")]
     OS_LIBS += CONFIG["MOZ_X11_LIBS"]
     OS_LIBS += CONFIG["MOZ_PANGO_LIBS"]
 

toolkit/mozapps/update/updater/updater-common.build

@@ -109,8 +109,8 @@ elif CONFIG["OS_ARCH"] == "WINNT":
     WIN32_EXE_LDFLAGS += ["-municode"]
 
 if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
-    CXXFLAGS += CONFIG["TK_CFLAGS"]
-    OS_LIBS += CONFIG["TK_LIBS"]
+    CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
+    OS_LIBS += CONFIG["MOZ_GTK3_LIBS"]
 
 if CONFIG["CC_TYPE"] == "gcc":
     CXXFLAGS += ["-Wno-format-truncation"]