Skip to content

Commit

Permalink
Bug 1517238 - [docs] Fix AttributeError: 'module' object has no attri…
Browse files Browse the repository at this point in the history
…bute 'DirEntry' when running |mach doc|, r=davehunt

This was happening because one of the modules sphinx generates apidocs for
started depending on scandir and our in-tree vendored copy of scandir doesn't
have the C module built. I'm still not sure why this is failing though (scandir
is supposed to fall-back to ctypes if the C module doesn't exist).

Either way, adding scandir to tools/docs/Pipfile works around the problem.

Differential Revision: https://phabricator.services.mozilla.com/D15571

--HG--
extra : moz-landing-system : lando
  • Loading branch information
ahal committed Jan 2, 2019
1 parent 6023889 commit b765d8e
Show file tree
Hide file tree
Showing 2 changed files with 116 additions and 73 deletions.
1 change: 1 addition & 0 deletions tools/docs/Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ backports-abc = "*"
boto3 = "*"
livereload = "*"
recommonmark = "*"
scandir = "*"
singledispatch = "*"
sphinx = "*"
# Upgrading to 2.5 causes an intermittent in the Doc task
Expand Down
188 changes: 115 additions & 73 deletions tools/docs/Pipfile.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b765d8e

Please sign in to comment.