Bug 1743570 - Always validate schemas in RemoteSettingsExperimentLoad…

…er r=emcminn Differential Revision: https://phabricator.services.mozilla.com/D150692
dothq · Jul 12, 2022 · bfa5aab · bfa5aab
1 parent f922ff3
commit bfa5aab
Showing 1 changed file with 9 additions and 15 deletions.
diff --git a/toolkit/components/nimbus/lib/RemoteSettingsExperimentLoader.jsm b/toolkit/components/nimbus/lib/RemoteSettingsExperimentLoader.jsm
@@ -411,22 +411,16 @@ class _RemoteSettingsExperimentLoader {
           );
         }
 
-        if (feature.enabled ?? true) {
-          const result = validator.validate(value);
-          if (!result.valid) {
-            Cu.reportError(
-              `Experiment ${id} branch ${branchIdx} feature ${featureId} does not validate: ${JSON.stringify(
-                result.errors,
-                undefined,
-                2
-              )}`
-            );
-            return false;
-          }
-        } else {
-          lazy.log.debug(
-            `Experiment ${id} branch ${branchIdx} feature ${featureId} disabled; skipping validation`
+        const result = validator.validate(value);
+        if (!result.valid) {
+          Cu.reportError(
+            `Experiment ${id} branch ${branchIdx} feature ${featureId} does not validate: ${JSON.stringify(
+              result.errors,
+              undefined,
+              2
+            )}`
           );
+          return false;
         }
       }
     }