Bug 1814686 - Part 1b: Add nullable annotations to refcounted types i…

…n ipdl, r=ipc-reviewers,mccr8

Manual changes to make all refcounted types be marked as `nullable` after the
changes in part 1a. This was done without any investigation into whether the
actual types want to be nullable, in order to avoid code changes.

Differential Revision: https://phabricator.services.mozilla.com/D168889

accessible/ipc/DocAccessibleTypes.ipdlh

@@ -12,7 +12,7 @@ namespace a11y {
 struct CacheData
 {
   uint64_t ID;
-  AccAttributes Fields;
+  nullable AccAttributes Fields;
 };
 
 }

accessible/ipc/extension/mac/PDocAccessiblePlatformExt.ipdl

@@ -19,7 +19,7 @@ namespace a11y {
 struct TextAttributesRun {
   nsString Text;
   uint64_t ContainerID;
-  AccAttributes TextAttributes;
+  nullable AccAttributes TextAttributes;
 };
 
 

accessible/ipc/other/PDocAccessible.ipdl

@@ -32,7 +32,7 @@ struct AccessibleData
   AccType Type;
   AccGenericType GenericTypes;
   uint8_t RoleMapEntryIndex;
-  AccAttributes CacheFields;
+  nullable AccAttributes CacheFields;
 };
 
 union OriginDocument
@@ -55,7 +55,7 @@ struct BatchData
   double MinValue;
   double MaxValue;
   double Step;
-  AccAttributes Attributes;
+  nullable AccAttributes Attributes;
 };
 
 struct ShowEventData
@@ -167,7 +167,7 @@ child:
   [Nested=inside_sync] sync Value(uint64_t aID) returns(nsString value);
   [Nested=inside_sync] sync Help(uint64_t aID) returns(nsString help);
   [Nested=inside_sync] sync Description(uint64_t aID) returns(nsString desc);
-  [Nested=inside_sync] sync Attributes(uint64_t aID) returns(AccAttributes attributes);
+  [Nested=inside_sync] sync Attributes(uint64_t aID) returns(nullable AccAttributes attributes);
   [Nested=inside_sync] sync RelationByType(uint64_t aID, uint32_t aRelationType)
     returns(uint64_t[] targets);
   [Nested=inside_sync] sync Relations(uint64_t aID) returns(RelationTargets[] relations);
@@ -200,8 +200,8 @@ child:
   [Nested=inside_sync] sync CharAt(uint64_t aID, int32_t aOffset) returns(uint16_t aChar);
 
   [Nested=inside_sync] sync TextAttributes(uint64_t aID, bool aIncludeDefAttrs, int32_t aOffset)
-    returns(AccAttributes aAttributes, int32_t aStartOffset, int32_t aEndOffset);
-  [Nested=inside_sync] sync DefaultTextAttributes(uint64_t aID) returns(AccAttributes aAttributes);
+    returns(nullable AccAttributes aAttributes, int32_t aStartOffset, int32_t aEndOffset);
+  [Nested=inside_sync] sync DefaultTextAttributes(uint64_t aID) returns(nullable AccAttributes aAttributes);
 
   [Nested=inside_sync] sync TextBounds(uint64_t aID, int32_t aStartOffset, int32_t aEndOffset,
                              uint32_t aCoordType)
@@ -357,7 +357,7 @@ child:
   /*
    * Verify the cache. Used for testing purposes.
    */
-  async VerifyCache(uint64_t aID, uint64_t aCacheDomain, AccAttributes aFields);
+  async VerifyCache(uint64_t aID, uint64_t aCacheDomain, nullable AccAttributes aFields);
 
 };
 

accessible/ipc/win/PDocAccessible.ipdl

@@ -33,7 +33,7 @@ struct AccessibleData
   AccType Type;
   AccGenericType GenericTypes;
   uint8_t RoleMapEntryIndex;
-  AccAttributes CacheFields;
+  nullable AccAttributes CacheFields;
 };
 
 struct ShowEventData
@@ -145,7 +145,7 @@ child:
   /*
    * Verify the cache. Used for testing purposes.
    */
-  async VerifyCache(uint64_t aID, uint64_t aCacheDomain, AccAttributes aFields);
+  async VerifyCache(uint64_t aID, uint64_t aCacheDomain, nullable AccAttributes aFields);
 
   async DoActionAsync(uint64_t aID, uint8_t aIndex);
 

dom/cache/CacheTypes.ipdlh

@@ -81,7 +81,7 @@ struct CacheResponse
   HeadersEntry[] headers;
   HeadersGuardEnum headersGuard;
   CacheReadStream? body;
-  nsITransportSecurityInfo securityInfo;
+  nullable nsITransportSecurityInfo securityInfo;
   PrincipalInfo? principalInfo;
   uint32_t paddingInfo;
   int64_t paddingSize;

dom/fetch/FetchTypes.ipdlh

@@ -36,7 +36,7 @@ struct ParentToParentStream {
 };
 
 union ParentToChildStream {
-  RemoteLazyInputStream;
+  nullable RemoteLazyInputStream;
   IPCStream;
 };
 
@@ -85,7 +85,7 @@ struct InternalResponseMetadata {
   HeadersEntry[] headers;
   nsresult errorCode;
   nsCString alternativeDataType;
-  nsITransportSecurityInfo securityInfo;
+  nullable nsITransportSecurityInfo securityInfo;
   PrincipalInfo? principalInfo;
   nsCString bodyBlobURISpec;
   nsString bodyLocalPath;

dom/file/ipc/IPCBlob.ipdlh

@@ -14,7 +14,7 @@ union RemoteLazyStream
 {
   // Parent to Child: The child will receive a RemoteLazyInputStream. Nothing
   // can be done with it except retrieving the size.
-  RemoteLazyInputStream;
+  nullable RemoteLazyInputStream;
 
   // Child to Parent: Normal serialization.
   IPCStream;

dom/ipc/DOMTypes.ipdlh

@@ -50,7 +50,6 @@ using mozilla::dom::MaybeDiscardedBrowsingContext from "mozilla/dom/BrowsingCont
 [RefCounted] using class nsIReferrerInfo from "nsIReferrerInfo.h";
 [RefCounted] using class nsIVariant from "nsIVariant.h";
 using mozilla::TimeStamp from "mozilla/TimeStamp.h";
-[RefCounted] using class mozilla::dom::BrowsingContext from "mozilla/dom/BrowsingContext.h";
 [RefCounted] using class mozilla::RemoteLazyInputStream from "mozilla/RemoteLazyInputStream.h";
 [MoveOnly] using class mozilla::ipc::BigBuffer from "mozilla/ipc/BigBuffer.h";
 
@@ -192,9 +191,9 @@ struct FeaturePolicyInfo
   nsString[]   inheritedDeniedFeatureNames;
   nsString[]   attributeEnabledFeatureNames;
   nsString     declaredString;
-  nsIPrincipal defaultOrigin;
-  nsIPrincipal selfOrigin;
-  nsIPrincipal srcOrigin;
+  nullable nsIPrincipal defaultOrigin;
+  nullable nsIPrincipal selfOrigin;
+  nullable nsIPrincipal srcOrigin;
 };
 
 /**
@@ -272,24 +271,24 @@ struct PerformanceInfo
 
 struct DocShellLoadStateInit
 {
-  nsIURI URI;
-  nsIURI OriginalURI;
-  nsIURI ResultPrincipalURI;
-  nsIPrincipal TriggeringPrincipal;
-  nsIReferrerInfo ReferrerInfo;
-  nsIPrincipal PrincipalToInherit;
-  nsIPrincipal PartitionedPrincipalToInherit;
-  nsIURI BaseURI;
+  nullable nsIURI URI;
+  nullable nsIURI OriginalURI;
+  nullable nsIURI ResultPrincipalURI;
+  nullable nsIPrincipal TriggeringPrincipal;
+  nullable nsIReferrerInfo ReferrerInfo;
+  nullable nsIPrincipal PrincipalToInherit;
+  nullable nsIPrincipal PartitionedPrincipalToInherit;
+  nullable nsIURI BaseURI;
   // The Content Security Policy of the load, that is, the CSP of the entity
   // responsible for causing the load to occur. Most likely this is the CSP
   // of the document that started the load. In case the entity starting the
   // load did not use a CSP, then Csp can be null. Please note that this is
   // also the CSP that will be applied to the load in case the load
   // encounters a server side redirect.
-  nsIContentSecurityPolicy Csp;
-  nsIInputStream PostDataStream;
-  nsIInputStream HeadersStream;
-  nsIURI UnstrippedURI;
+  nullable nsIContentSecurityPolicy Csp;
+  nullable nsIInputStream PostDataStream;
+  nullable nsIInputStream HeadersStream;
+  nullable nsIURI UnstrippedURI;
   uint64_t LoadIdentifier;
   nsString Target;
   nsCString TypeHint;
@@ -319,7 +318,6 @@ struct DocShellLoadStateInit
   uint32_t TriggeringSandboxFlags;
   int32_t? CancelContentJSEpoch;
 
-
   bool ResultPrincipalURIIsSome;
   bool KeepResultPrincipalURIIfSet;
   bool LoadReplace;
@@ -375,9 +373,9 @@ struct ReplacementChannelConfigInit
   ClassOfService classOfService;
   bool? privateBrowsing;
   nsCString? method;
-  nsIReferrerInfo referrerInfo;
+  nullable nsIReferrerInfo referrerInfo;
   TimedChannelInfo? timedChannelInfo;
-  RemoteLazyInputStream uploadStream;
+  nullable RemoteLazyInputStream uploadStream;
   uint64_t uploadStreamLength;
   bool uploadStreamHasHeaders;
   nsCString? contentType;
@@ -397,8 +395,8 @@ union IPDLVariantValue
   nsID;
   nsString;
   nsCString;
-  nsIURI;
-  nsIPrincipal;
+  nullable nsIURI;
+  nullable nsIPrincipal;
 };
 
 struct IDPLVariant
@@ -411,7 +409,7 @@ struct IDPLVariant
 struct IPDLProperty
 {
   nsString name;
-  nsIVariant value;
+  nullable nsIVariant value;
 };
 
 // Struct with information to show a frame from the parent process.

dom/ipc/PBrowser.ipdl

@@ -122,8 +122,8 @@ struct WebProgressData
 
 struct RequestData
 {
-  nsIURI requestURI;
-  nsIURI originalRequestURI;
+  nullable nsIURI requestURI;
+  nullable nsIURI originalRequestURI;
   nsCString matchedList;
 };
 
@@ -136,7 +136,7 @@ struct WebProgressStateChangeData
   // this struct is |nsIWebProgress.STATE_STOP|.
   nsString contentType;
   nsString charset;
-  nsIURI documentURI;
+  nullable nsIURI documentURI;
 };
 
 struct WebProgressLocationChangeData
@@ -147,11 +147,11 @@ struct WebProgressLocationChangeData
   nsString contentType;
   nsString title;
   nsString charset;
-  nsIURI documentURI;
-  nsIPrincipal contentPrincipal;
-  nsIPrincipal contentPartitionedPrincipal;
-  nsIContentSecurityPolicy csp;
-  nsIReferrerInfo referrerInfo;
+  nullable nsIURI documentURI;
+  nullable nsIPrincipal contentPrincipal;
+  nullable nsIPrincipal contentPartitionedPrincipal;
+  nullable nsIContentSecurityPolicy csp;
+  nullable nsIReferrerInfo referrerInfo;
   uint64_t? requestContextID;
 };
 
@@ -531,16 +531,16 @@ parent:
 
     async AccessKeyNotHandled(WidgetKeyboardEvent event);
 
-    async RegisterProtocolHandler(nsString scheme, nsIURI handlerURI, nsString title,
-                                  nsIURI documentURI);
+    async RegisterProtocolHandler(nsString scheme, nullable nsIURI handlerURI, nsString title,
+                                  nullable nsIURI documentURI);
 
     async OnStateChange(WebProgressData aWebProgressData,
                         RequestData aRequestData, uint32_t aStateFlags,
                         nsresult aStatus,
                         WebProgressStateChangeData? aStateChangeData);
 
     async OnLocationChange(WebProgressData aWebProgressData,
-                           RequestData aRequestData, nsIURI aLocation,
+                           RequestData aRequestData, nullable nsIURI aLocation,
                            uint32_t aFlags, bool aCanGoBack,
                            bool aCanGoForward,
                            WebProgressLocationChangeData? aLocationChangeData);
@@ -632,7 +632,8 @@ parent:
                             BigBuffer? visualData,
                             uint32_t stride, SurfaceFormat format,
                             LayoutDeviceIntRect dragRect,
-                            nsIPrincipal principal, nsIContentSecurityPolicy csp,
+                            nullable nsIPrincipal principal,
+                            nullable nsIContentSecurityPolicy csp,
                             CookieJarSettingsArgs cookieJarSettings,
                             MaybeDiscardedWindowContext sourceWindowContext,
                             MaybeDiscardedWindowContext sourceTopWindowContext);
@@ -693,10 +694,10 @@ child:
 
     async CompositorOptionsChanged(CompositorOptions newOptions);
 
-    async LoadURL(nsDocShellLoadState loadState, ParentShowInfo info);
+    async LoadURL(nullable nsDocShellLoadState loadState, ParentShowInfo info);
 
-    async CreateAboutBlankContentViewer(nsIPrincipal principal,
-                                        nsIPrincipal partitionedPrincipal);
+    async CreateAboutBlankContentViewer(nullable nsIPrincipal principal,
+                                        nullable nsIPrincipal partitionedPrincipal);
 
     async ResumeLoad(uint64_t pendingSwitchID, ParentShowInfo info);
 
@@ -844,8 +845,8 @@ child:
      * don't need support RealDragEvent with input priority.
      */
     async RealDragEvent(WidgetDragEvent aEvent, uint32_t aDragAction,
-                        uint32_t aDropEffect, nsIPrincipal aPrincipal,
-                        nsIContentSecurityPolicy csp);
+                        uint32_t aDropEffect, nullable nsIPrincipal aPrincipal,
+                        nullable nsIContentSecurityPolicy csp);
 
     [Priority=input] async CompositionEvent(WidgetCompositionEvent event);
     async NormalPriorityCompositionEvent(WidgetCompositionEvent event);
@@ -865,7 +866,7 @@ child:
      */
     async PasteTransferable(IPCDataTransfer aDataTransfer,
                             bool aIsPrivateData,
-                            nsIPrincipal aRequestingPrincipal,
+                            nullable nsIPrincipal aRequestingPrincipal,
                             nsContentPolicyType aContentPolicyType);
 
     async LoadRemoteScript(nsString aURL, bool aRunInGlobalScope);
@@ -1003,10 +1004,10 @@ parent:
     async IsWindowSupportingWebVR(uint64_t aOuterWindowID) returns(bool isSupported);
 
     /** Records a history visit. */
-    async VisitURI(nsIURI aURI, nsIURI aLastVisitedURI, uint32_t aFlags, uint64_t aBrowserId);
+    async VisitURI(nullable nsIURI aURI, nullable nsIURI aLastVisitedURI, uint32_t aFlags, uint64_t aBrowserId);
 
     /** Fetches the visited status for an array of URIs (Android-only). */
-    async QueryVisitedState(nsIURI[] aURIs);
+    async QueryVisitedState(nullable nsIURI[] aURIs);
 
     /** Create a session store for a browser child. */
     async PSessionStore();

dom/ipc/PBrowserBridge.ipdl

@@ -93,7 +93,7 @@ parent:
   async BeginDestroy();
 
   // DocShell messaging.
-  async LoadURL(nsDocShellLoadState aLoadState);
+  async LoadURL(nullable nsDocShellLoadState aLoadState);
   async ResumeLoad(uint64_t aPendingSwitchID);
 
   // Out of process rendering.