Skip to content

Commit

Permalink
Bug 1607153 - Remove the incorrect extra close of IPC channel client_…
Browse files Browse the repository at this point in the history
…pipe_. r=froydnj

It's no longer safe to try closing client_pipe_ when the I/O thread is
woken up with data from the child process, because that can race with the
launch thread doing its own close, and it's also unnecessary because of
that other close.  See also bug 1607153 comment #2.

Differential Revision: https://phabricator.services.mozilla.com/D60627

--HG--
extra : moz-landing-system : lando
  • Loading branch information
jld committed Jan 22, 2020
1 parent 1eef62f commit c6b8eb2
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions ipc/chromium/src/chrome/common/ipc_channel_posix.cc
Original file line number Diff line number Diff line change
Expand Up @@ -370,12 +370,6 @@ bool Channel::ChannelImpl::ProcessIncomingMessages() {
}
DCHECK(bytes_read);

if (client_pipe_ != -1) {
PipeMap::instance().Remove(pipe_name_);
IGNORE_EINTR(close(client_pipe_));
client_pipe_ = -1;
}

// a pointer to an array of |num_wire_fds| file descriptors from the read
const int* wire_fds = NULL;
unsigned num_wire_fds = 0;
Expand Down

0 comments on commit c6b8eb2

Please sign in to comment.