Bug 1822037 - don't bother setting isAppTab for extension browsers, r…

…=rpl Differential Revision: https://phabricator.services.mozilla.com/D173089
dothq · Mar 24, 2023 · cafaec2 · cafaec2
1 parent fafcedc
commit cafaec2
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 10 deletions.
diff --git a/browser/base/content/webext-panels.js b/browser/base/content/webext-panels.js
@@ -124,8 +124,6 @@ function getBrowser(panel) {
   };
 
   browser.addEventListener("DidChangeBrowserRemoteness", initBrowser);
-  // Potentially unnecessary: bug 1822037 will evaluate further.
-  browser.browsingContext.isAppTab = true;
   return readyPromise.then(initBrowser);
 }
 

diff --git a/browser/components/extensions/ExtensionPopups.jsm b/browser/components/extensions/ExtensionPopups.jsm
@@ -403,8 +403,6 @@ class BasePopup {
     };
 
     browser.addEventListener("DidChangeBrowserRemoteness", initBrowser); // eslint-disable-line mozilla/balanced-listeners
-    // Potentially unnecessary: bug 1822037 will evaluate further.
-    browser.browsingContext.isAppTab = true;
 
     if (!popupURL) {
       // For remote browsers, we can't do any setup until the frame loader is

diff --git a/toolkit/components/extensions/ExtensionParent.jsm b/toolkit/components/extensions/ExtensionParent.jsm
@@ -512,10 +512,6 @@ GlobalManager = {
     data.viewType = browser.getAttribute("webextension-view-type");
     if (data.viewType) {
       GlobalManager.frameData.set(browser, data);
-      // Potentially unnecessary: bug 1822037 will evaluate further.
-      browser.browsingContext.isAppTab = ["popup", "sidebar"].includes(
-        data.viewType
-      );
     }
   },
 

diff --git a/toolkit/mozapps/extensions/content/aboutaddons.js b/toolkit/mozapps/extensions/content/aboutaddons.js
@@ -1849,8 +1849,6 @@ class InlineOptionsBrowser extends HTMLElement {
         browserOptions.stylesheets = extensionStylesheets;
       }
 
-      // Potentially unnecessary: bug 1822037 will evaluate further.
-      browser.browsingContext.isAppTab = true;
       mm.sendAsyncMessage("Extension:InitBrowser", browserOptions);
 
       if (browser.isConnectedAndReady) {