Skip to content

Commit

Permalink
Backed out changeset c87b7ace41f7 (bug 1651986) for Reftest failure a…
Browse files Browse the repository at this point in the history
…t border-image-linear-gradient-slice-1.html. CLOSED TREE
  • Loading branch information
Butkovits Atila committed Jul 17, 2020
1 parent 1d11c9f commit d02d733
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 79 deletions.
20 changes: 1 addition & 19 deletions browser/modules/BrowserUsageTelemetry.jsm
Original file line number Diff line number Diff line change
Expand Up @@ -156,18 +156,6 @@ const BROWSER_UI_CONTAINER_IDS = {
"nav-bar": "nav-bar",
};

// A list of the expected panes in about:preferences
const PREFERENCES_PANES = [
"paneHome",
"paneGeneral",
"panePrivacy",
"paneSearch",
"paneSearchResults",
"paneSync",
"paneContainers",
"paneExperimental",
];

const IGNORABLE_EVENTS = new WeakMap();

const KNOWN_ADDONS = [];
Expand Down Expand Up @@ -974,13 +962,7 @@ let BrowserUsageTelemetry = {
return null;
}

let pane = container.getAttribute("data-category");

if (!PREFERENCES_PANES.includes(pane)) {
pane = "paneUnknown";
}

return `preferences_${pane}`;
return `preferences_${container.getAttribute("data-category")}`;
}

return null;
Expand Down
81 changes: 21 additions & 60 deletions toolkit/components/telemetry/Scalars.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ browser.ui:
- 1620358
description: >
The widgets in the toolbars.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: boolean
keyed: true
Expand All @@ -631,7 +631,7 @@ browser.ui:
- 1620358
description: >
Records when widgets are added, removed or moved in the UI.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: uint
keyed: true
Expand All @@ -650,7 +650,7 @@ browser.ui.interaction:
- 1620358
description: >
Records a count of interactions with keyboard shortcuts.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: uint
keyed: true
Expand All @@ -668,7 +668,7 @@ browser.ui.interaction:
- 1620358
description: >
Records a count of interactions with items in the menu bar.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: uint
keyed: true
Expand All @@ -686,7 +686,7 @@ browser.ui.interaction:
- 1620358
description: >
Records a count of interactions with items in the tab bar.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: uint
keyed: true
Expand All @@ -704,7 +704,7 @@ browser.ui.interaction:
- 1620358
description: >
Records a count of interactions with items in the nav bar.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: uint
keyed: true
Expand All @@ -722,7 +722,7 @@ browser.ui.interaction:
- 1620358
description: >
Records a count of interactions with items in the bookmarks bar.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: uint
keyed: true
Expand All @@ -740,7 +740,7 @@ browser.ui.interaction:
- 1620358
description: >
Records a count of interactions with items in the app menu.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: uint
keyed: true
Expand All @@ -758,7 +758,7 @@ browser.ui.interaction:
- 1620358
description: >
Records a count of interactions with items in the tab context menu.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: uint
keyed: true
Expand All @@ -776,7 +776,7 @@ browser.ui.interaction:
- 1620358
description: >
Records a count of interactions with items in the content context menu.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: uint
keyed: true
Expand All @@ -794,7 +794,7 @@ browser.ui.interaction:
- 1620358
description: >
Records a count of interactions with items in the overflow menu.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: uint
keyed: true
Expand All @@ -813,7 +813,7 @@ browser.ui.interaction:
description: >
Records a count of interactions with items in the pinned area of the
overflow menu.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: uint
keyed: true
Expand All @@ -831,7 +831,7 @@ browser.ui.interaction:
- 1620358
description: >
Records a count of interactions with page action items in the url bar.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: uint
keyed: true
Expand All @@ -849,7 +849,7 @@ browser.ui.interaction:
- 1620358
description: >
Records a count of interactions with page action items in the panel.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: uint
keyed: true
Expand All @@ -867,7 +867,7 @@ browser.ui.interaction:
- 1620358
description: >
Records the items interacted with in the Home section of preferences.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: uint
keyed: true
Expand All @@ -885,7 +885,7 @@ browser.ui.interaction:
- 1620358
description: >
Records the items interacted with in the General section of preferences.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: uint
keyed: true
Expand All @@ -903,7 +903,7 @@ browser.ui.interaction:
- 1620358
description: >
Records the items interacted with in the Privacy section of preferences.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: uint
keyed: true
Expand All @@ -921,7 +921,7 @@ browser.ui.interaction:
- 1620358
description: >
Records the items interacted with in the Search section of preferences.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: uint
keyed: true
Expand All @@ -940,7 +940,7 @@ browser.ui.interaction:
description: >
Records the items interacted with in the Search results section of
preferences.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: uint
keyed: true
Expand All @@ -958,7 +958,7 @@ browser.ui.interaction:
- 1620358
description: >
Records the items interacted with in the Sync section of preferences.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: uint
keyed: true
Expand All @@ -977,46 +977,7 @@ browser.ui.interaction:
description: >
Records the items interacted with in the Containers section of
preferences.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
expires: never
kind: uint
keyed: true
notification_emails:
- [email protected]
- [email protected]
release_channel_collection: opt-out
products:
- 'firefox'
record_in_processes:
- 'main'

preferences_paneExperimental:
bug_numbers:
- 1620358
- 1651986
description: >
Records the items interacted with in the Experimental section of
preferences.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
expires: never
kind: uint
keyed: true
notification_emails:
- [email protected]
- [email protected]
release_channel_collection: opt-out
products:
- 'firefox'
record_in_processes:
- 'main'

preferences_paneUnknown:
bug_numbers:
- 1620358
- 1651986
description: >
Records the items interacted with in any other section of preferences.
See https://firefox-source-docs.mozilla.org/browser/BrowserUsageTelemetry.html
See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/ecosystem-telemetry.html
expires: never
kind: uint
keyed: true
Expand Down

0 comments on commit d02d733

Please sign in to comment.