Bug 1750040 - wasm: Enable wasm exception handling in nightly. r=lth

Differential Revision: https://phabricator.services.mozilla.com/D136630
dothq · Jan 31, 2022 · d4d2cb3 · d4d2cb3
1 parent b1a8fa9
commit d4d2cb3
Show file tree

Hide file tree

Showing 13 changed files with 208 additions and 90 deletions.
diff --git a/dom/serviceworkers/test/test_serviceworker_interfaces.js b/dom/serviceworkers/test/test_serviceworker_interfaces.js
@@ -40,6 +40,16 @@ var wasmGlobalInterfaces = [
     insecureContext: true,
     nightly: true,
   },
+  {
+    name: "Exception",
+    insecureContext: true,
+    nightly: true,
+  },
+  {
+    name: "Tag",
+    insecureContext: true,
+    nightly: true,
+  },
 ];
 // IMPORTANT: Do not change this list without review from
 //            a JavaScript Engine peer!

diff --git a/dom/tests/mochitest/general/test_interfaces.js b/dom/tests/mochitest/general/test_interfaces.js
@@ -68,6 +68,16 @@ var wasmGlobalInterfaces = [
     insecureContext: true,
     nightly: true,
   },
+  {
+    name: "Exception",
+    insecureContext: true,
+    nightly: true,
+  },
+  {
+    name: "Tag",
+    insecureContext: true,
+    nightly: true,
+  },
 ];
 // IMPORTANT: Do not change this list without review from
 //            a JavaScript Engine peer!

diff --git a/dom/workers/test/test_worker_interfaces.js b/dom/workers/test/test_worker_interfaces.js
@@ -46,6 +46,16 @@ var wasmGlobalInterfaces = [
     insecureContext: true,
     nightly: true,
   },
+  {
+    name: "Exception",
+    insecureContext: true,
+    nightly: true,
+  },
+  {
+    name: "Tag",
+    insecureContext: true,
+    nightly: true,
+  },
 ];
 // IMPORTANT: Do not change this list without review from
 //            a JavaScript Engine peer!

diff --git a/js/public/WasmFeatures.h b/js/public/WasmFeatures.h
@@ -113,7 +113,7 @@
                /* flag predicate     */ true,                                 \
                /* shell flag         */ "extended-const",                     \
                /* preference name    */ "extended_const")                     \
-  EXPERIMENTAL(                                                               \
+  TENTATIVE(                                                                  \
       /* capitalized name   */ Exceptions,                                    \
       /* lower case name    */ exceptions,                                    \
       /* compile predicate  */ WASM_EXCEPTIONS_ENABLED,                       \

diff --git a/modules/libpref/init/StaticPrefList.yaml b/modules/libpref/init/StaticPrefList.yaml
@@ -6666,7 +6666,7 @@
 #if defined(ENABLE_WASM_EXCEPTIONS)
 -   name: javascript.options.wasm_exceptions
     type: bool
-    value: false
+    value: @IS_NIGHTLY_BUILD@
     mirror: always
 #endif // defined(ENABLE_WASM_EXCEPTIONS)
 

diff --git a/testing/web-platform/meta/wasm/jsapi/exception/basic.tentative.any.js.ini b/testing/web-platform/meta/wasm/jsapi/exception/basic.tentative.any.js.ini
@@ -1,83 +1,108 @@
 [basic.tentative.any.worker.html]
   [Wasm function throws argument]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Wasm function throws null]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Wasm function throws integer]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Imported JS function throws]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Imported JS function throws, Wasm catches and rethrows]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
 
 [basic.tentative.any.serviceworker.html]
   [Wasm function throws argument]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Wasm function throws null]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Wasm function throws integer]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Imported JS function throws]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Imported JS function throws, Wasm catches and rethrows]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
 
 [basic.tentative.any.sharedworker.html]
   [Wasm function throws argument]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Wasm function throws null]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Wasm function throws integer]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Imported JS function throws]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Imported JS function throws, Wasm catches and rethrows]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
 
 [basic.tentative.any.html]
   [Wasm function throws argument]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Wasm function throws null]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Wasm function throws integer]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Imported JS function throws]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Imported JS function throws, Wasm catches and rethrows]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
 
 [basic.tentative.any.js]
   [Wasm function throws argument]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Wasm function throws null]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Wasm function throws integer]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Imported JS function throws]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Imported JS function throws, Wasm catches and rethrows]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
diff --git a/testing/web-platform/meta/wasm/jsapi/exception/constructor.tentative.any.js.ini b/testing/web-platform/meta/wasm/jsapi/exception/constructor.tentative.any.js.ini
@@ -1,40 +1,52 @@
 [constructor.tentative.any.worker.html]
   [name]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [length]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Calling]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Invalid exception argument]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
 
 [constructor.tentative.any.html]
   [name]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [length]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Calling]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Invalid exception argument]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
 
 [constructor.tentative.any.js]
   [name]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [length]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Calling]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Invalid exception argument]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
diff --git a/testing/web-platform/meta/wasm/jsapi/exception/getArg.tentative.any.js.ini b/testing/web-platform/meta/wasm/jsapi/exception/getArg.tentative.any.js.ini
@@ -1,49 +1,64 @@
 [getArg.tentative.any.worker.html]
   [Missing arguments]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Invalid exception argument]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Index out of bounds]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Getting out-of-range argument]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [getArg]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
 
 [getArg.tentative.any.html]
   [Missing arguments]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Invalid exception argument]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Index out of bounds]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Getting out-of-range argument]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [getArg]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
 
 [getArg.tentative.any.js]
   [Missing arguments]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Invalid exception argument]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Index out of bounds]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Getting out-of-range argument]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [getArg]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
diff --git a/testing/web-platform/meta/wasm/jsapi/exception/is.tentative.any.js.ini b/testing/web-platform/meta/wasm/jsapi/exception/is.tentative.any.js.ini
@@ -1,31 +1,40 @@
 [is.tentative.any.html]
   [Missing arguments]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Invalid exception argument]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [is]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
 
 [is.tentative.any.worker.html]
   [Missing arguments]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Invalid exception argument]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [is]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
 
 [is.tentative.any.js]
   [Missing arguments]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [Invalid exception argument]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL
 
   [is]
-    expected: FAIL
+    expected:
+      if release_or_beta: FAIL