Bug 1533406 - Extend private browsing lifetime for gecko view too. r=…

…smaug

Private browsing data kept getting cleared each time a new tab was created
since gecko thought there were no more private windows. Also, fixes a typo
in the case of "windowtype".

Differential Revision: https://phabricator.services.mozilla.com/D60330

--HG--
extra : moz-landing-system : lando

dom/xul/nsXULElement.cpp

@@ -107,7 +107,9 @@ nsXULElement::~nsXULElement() {}
 
 void nsXULElement::MaybeUpdatePrivateLifetime() {
   if (AttrValueIs(kNameSpaceID_None, nsGkAtoms::windowtype,
-                  NS_LITERAL_STRING("navigator:browser"), eCaseMatters)) {
+                  NS_LITERAL_STRING("navigator:browser"), eCaseMatters) ||
+      AttrValueIs(kNameSpaceID_None, nsGkAtoms::windowtype,
+                  NS_LITERAL_STRING("navigator:geckoview"), eCaseMatters)) {
     return;
   }
 

mobile/android/chrome/geckoview/geckoview.js

@@ -200,7 +200,7 @@ var ModuleManager = {
     const windowType = aSettings.isPopup
       ? "navigator:popup"
       : "navigator:geckoview";
-    window.document.documentElement.setAttribute("windowType", windowType);
+    window.document.documentElement.setAttribute("windowtype", windowType);
 
     this.forEach(module => {
       if (module.impl) {